[Bug 16515] New: Did you mean? links don't wrap on smaller screens
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Bug ID: 16515 Summary: Did you mean? links don't wrap on smaller screens Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When you have turned on "did you mean" suggestions in the OPAC, the text in the yellow box won't wrap on smaller screens. This is because of: .searchsuggestion { white-space: nowrap; } .searchsuggestion { white-space: normal } in OpacUserCSS seems to fix it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For instructions on how to change the OPAC CSS files see: https://wiki.koha-community.org/wiki/Working_with_Bootstrap_OPAC_LESS_files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Zoe Schoeler <crazy.mental.onion@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crazy.mental.onion@gmail.co | |m --- Comment #2 from Zoe Schoeler <crazy.mental.onion@gmail.com> --- Created attachment 59112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59112&action=edit Screenshot Katrin, is this what you mean? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #3 from Zoe Schoeler <crazy.mental.onion@gmail.com> --- Created attachment 59115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59115&action=edit Second Screenshot This is what it looks like after applying the css, is this the result you wanted? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Zoe, it's a bit hard to tell from the screenshots, but it looks like the yellow box is contained inside the 'white box', so that should work better when there is more text from the plugins. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 63128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63128&action=edit Bug 16515 - Did you mean? links don't wrap on smaller screens This patch tweaks some CSS in the OPAC to give the "Did you mean" block better layout on smaller screens. To test, apply the patch and process LESS files. Enable "Did you mean" plugins for the OPAC in Administration. Perform a search in the OPAC and confirm that the "Did you mean" block looks correct. Resize your browser to various widths and confirm that the block handles all sizes well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 63129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63129&action=edit Bug 16515 [Generated CSS] Did you mean? links don't wrap on smaller screens Processed and minified CSS. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63129|0 |1 is obsolete| | --- Comment #7 from dilan@calyx.net.au --- Created attachment 63317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63317&action=edit Bug 16515 [Generated CSS] Did you mean? links don't wrap on smaller screens Processed and minified CSS. Works as expected and looks much tidier now. Signed-off-by: Dilan Johnpulle <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 dilan@calyx.net.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan@calyx.net.au --- Comment #8 from dilan@calyx.net.au --- Created attachment 63318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63318&action=edit Screenshot after applying patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63128|0 |1 is obsolete| | Attachment #63317|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63338&action=edit Bug 16515 - Did you mean? links don't wrap on smaller screens This patch tweaks some CSS in the OPAC to give the "Did you mean" block better layout on smaller screens. To test, apply the patch and process LESS files. Enable "Did you mean" plugins for the OPAC in Administration. Perform a search in the OPAC and confirm that the "Did you mean" block looks correct. Resize your browser to various widths and confirm that the block handles all sizes well. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63339&action=edit Bug 16515 [Generated CSS] Did you mean? links don't wrap on smaller screens Processed and minified CSS. Works as expected and looks much tidier now. Signed-off-by: Dilan Johnpulle <dilan@calyx.net.au> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ...patches even -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x for 3.22.21 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16515 --- Comment #15 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.13 release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org