https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25629 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 105442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105442&action=edit Bug 25629: Fix capitalization in sample notices This fixes the capitalization in sample notices files to follow coding-guidelines. Only applies to English, translations remain unchanged. Additional fixes: - Overdues slip added the letter code as subject instead of the description - Opac changed to OPAC for self-registration verification emails German (de-DE) file was not changed, as there is a pending translation bug that will take care of these (bug 25129). To test: - Verify changes by running the web installer for the changed files and verify sample notices install without error - Verify subjects and notice descriptions are correct - Run tests in t/db_dependent/Letters* -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25629 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105442|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 106635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106635&action=edit Bug 25629: Fix capitalization in sample notices This fixes the capitalization in sample notices files to follow coding-guidelines. Only applies to English, translations remain unchanged. Additional fixes: - Overdues slip added the letter code as subject instead of the description - Opac changed to OPAC for self-registration verification emails German (de-DE) file was not changed, as there is a pending translation bug that will take care of these (bug 25129). To test: - Verify changes by running the web installer for the changed files and verify sample notices install without error - Verify subjects and notice descriptions are correct - Run tests in t/db_dependent/Letters* Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25629 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice fix, Passing QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25629 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25629 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.