[Bug 18170] New: Show damaged status on check-in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Bug ID: 18170 Summary: Show damaged status on check-in Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: lisetteslatah@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It would be nice if when checking in an item we could see if it has a damaged status without opening a new tab to see. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Lisette <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 koha-US bug tracker <bugzilla@koha-us.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla@koha-us.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Heather <heather_hernandez@nps.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Tomáš Wünsch <fraktik@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fraktik@gmail.com --- Comment #2 from Tomáš Wünsch <fraktik@gmail.com> --- +1 ;-) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Jennifer Marlatt <jennifer.marlatt@coronaca.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jennifer.marlatt@coronaca.g | |ov --- Comment #3 from Jennifer Marlatt <jennifer.marlatt@coronaca.gov> --- This would be very helpful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 110703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110703&action=edit Bug 18170: Show damaged status in table of checkins This copies the display of the damaged status from the holds and checkouts pages in staff. To test: - Apply patch - Check out some items, some damaged, others not - Verify the damaged status is displayed below the due date in the table of checkouts - Check the items in from the checkin page - Verify the damaged status displays in the table of checkins -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I had a go at this, please let me know if it works for you :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110703|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 110705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110705&action=edit Bug 18170: Show damaged status in table of checkins This copies the display of the damaged status from the holds and checkouts pages in staff. To test: - Apply patch - Check out some items, some damaged, others not - Verify the damaged status is displayed below the due date in the table of checkouts - Check the items in from the checkin page - Verify the damaged status displays in the table of checkins Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Lisette Scheer <lisetteslatah@gmail.com> --- Worked great for me! Damaged status showed in the due date box on the check in screen just like it does on the check out screen. Thanks! Lisette -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21883 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Like asked in Bug 21883 we need to pass item object to page. Also from Bug 26323 we avoid using directly AV category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think no need to put this In Discussion here - I can fix the hardcoded Authorised value, but I think changing it all to work on an items object is a little too big for me. Can we agree to handle that separately? I also still think we make our lives too hard by not relying on some hardcoded Authorised value codes - documentation and all are refering to them and it makes life tons easier. And: we do have hardocded ones outside of catalouging already. But I have said so on the other bug already. ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 --- Comment #10 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Katrin Fischer from comment #9)
I think no need to put this In Discussion here - I can fix the hardcoded Authorised value, but I think changing it all to work on an items object is a little too big for me. Can we agree to handle that separately? Totally agree. And my mistake, this patch impacts items in history table, Bug 21883 impacts item currently returned. So not exactly the same.
I hope we can push both bugs before refactoring with item object. ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26323 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, as much as I can see the argument for refactoring this to return an items resultset (or a checkouts resultset really) for code clarity I get the distinct feeling it could have a detrimental effect on performance too (i.e right now we fetch the details once, then pass what we need back and fourth in the template and controller.. such a refactor would mean passing back just a list of ID's and then refecthing the data from the database with each action.. unless I'm missing an way to not require that). In short.. I think this one should move as is. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Sooo... on the QA front.. I have an alternate failure I'm afraid. We need to use the KohaField version of the template plugin I think to ensure we get the right mapped AV set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110705|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111041&action=edit Bug 18170: Show damaged status in table of checkins This copies the display of the damaged status from the holds and checkouts pages in staff. To test: - Apply patch - Check out some items, some damaged, others not - Verify the damaged status is displayed below the due date in the table of checkouts - Check the items in from the checkin page - Verify the damaged status displays in the table of checkins Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111042&action=edit Bug 18170: Use GetDescriptionByKohaField -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thank you, Martin, I didn't get around to it yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111041|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111639&action=edit Bug 18170: Show damaged status in table of checkins This copies the display of the damaged status from the holds and checkouts pages in staff. To test: - Apply patch - Check out some items, some damaged, others not - Verify the damaged status is displayed below the due date in the table of checkouts - Check the items in from the checkin page - Verify the damaged status displays in the table of checkins Signed-off-by: Lisette Scheer <lisetteslatah@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111042|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111640&action=edit Bug 18170: Use GetDescriptionByKohaField Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Signing Martin's follow-up - the original patch has an external sign-off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org