https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |wainuiwitikapark@catalyst.n |ity.org |et.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161720|0 |1 is obsolete| | --- Comment #2 from wainuiwitikapark@catalyst.net.nz --- Created attachment 161859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161859&action=edit Bug 35953: Add delete_any_record cataloguing subpermission To test: - apply patch - create a new test user - give the test user "catalogue" permissions so that they can enter the staff interface - also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission - login to the staff interface as the test user - do a catalogue search - click on a result and go to their biblio details page - notice there is an "Edit" button dropdown - click on the "Edit" button dropdown and notice there is no option to "Delete record" - change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission - do another catalogue search and click on the result - click on the "Edit" button dropdown and notice there is now an option to "Delete record" Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161859|0 |1 is obsolete| | --- Comment #3 from wainuiwitikapark@catalyst.net.nz --- Created attachment 162129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162129&action=edit Bug 35953: Add delete_any_record cataloguing subpermission To test: - apply patch - create a new test user - give the test user "catalogue" permissions so that they can enter the staff interface - also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission - login to the staff interface as the test user - do a catalogue search - click on a result and go to their biblio details page - notice there is an "Edit" button dropdown - click on the "Edit" button dropdown and notice there is no option to "Delete record" - change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission - do another catalogue search and click on the result - click on the "Edit" button dropdown and notice there is now an option to "Delete record" Sponsored-by: Education Services Australia SCIS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162129|0 |1 is obsolete| | --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 162402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162402&action=edit Works as described: Bug 35953: Add delete_any_record cataloguing subpermission To test: - apply patch - create a new test user - give the test user "catalogue" permissions so that they can enter the staff interface - also give the test user the "edit_catalogue" subpermission under the "editcatalogue" permission - login to the staff interface as the test user - do a catalogue search - click on a result and go to their biblio details page - notice there is an "Edit" button dropdown - click on the "Edit" button dropdown and notice there is no option to "Delete record" - change the permissions of the test user to also have "delete_any_record" subpermission under the "editcatalogue" permission - do another catalogue search and click on the result - click on the "Edit" button dropdown and notice there is now an option to "Delete record" Sponsored-by: Education Services Australia SCIS Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Can we get some explanation here on what the purpose is? If I understand, this is to remove 'deletion' from 'edit_catalogue' and make it a new standalone permission? If correct we also need to grant the permission existing users with 'editcatalogue' in the database update I find 'delete_any_record' confusing - edit_any_item is because there are items that can be restricted - are there records that could be restricted and not possible to delete? This plan/patch does not cover authorities, which would be implied by 'any' record. I do see that 'acquisition->order_manage' seems to grant the ability to delete order related biblios And the tools permissions for batch deletion allow you to delete items/bibs without cataloging permissions Have you verified there are not other places from which a biblio can be deleted? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi --- Comment #7 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- Bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39848 removed the ability to delete records from batch item deletion if the user does not have edit_catalogue permission. This is a problem for us because our users without edit_catalogue have used batch item deletion to delete bibliographic records. We do not want to give everyone the permission to edit catalogue because it is a job that takes lot of comptence and should not be done by those who do not know the rules. :) So with that change, it seems that we need a new permission that allows user to delete bibliographic records and not edit them. Permission named delete_catalogue or delete_biblio_records would sound consistent to me. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|wainuiwitikapark@catalyst.n |emmi.takkinen@koha-suomi.fi |et.nz | --- Comment #8 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I'm assigning this to myself with permission from Wainui. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 --- Comment #10 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 190282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190282&action=edit Bug 35953: Rename delete_any_record as delete_bibliographic_records Rename new permission for deleting bibliographic records as delete_any_record. Also rename atomicupdate file and update it to follow current skeleton.pl file example. To test: 1. Apply this patch. 2. Run updatedatabase.pl. => Confirm this new permission was added to Koha. 3. Follow test plan from previous patch. => Confirm everything works as described. Sponsored by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 --- Comment #13 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 191245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191245&action=edit Bug 35953: Do not show Catalogue modal if patron only has permission to delete bibliographic records If patron has only delete_bibliographic_records permission the link to Catalogue modal is still displayed although patron has no permissions to use functions or tools to edit bibliographic record or items. This patch hides the modal link if patron has only delete_bibliographic_records permission. To test: 1. Add delete_bibliographic_records to patron, but to not add any other permissions for them from editcatalogue permissions. 2. Navigate to the main page. => Note that link to the Catalogue modal is displayed. 3. Apply this patch and refresh the main page. => Note that link to the Catalogue modal is no longer displayed. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 --- Comment #16 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- (In reply to Emmanuel Bétemps from comment #15)

Hi,

I don't find the delete_bibliographic_records permission but rather, the records_batchdel one

is records_batchdel the one to check ?

have a nice day

Manu.

Ah, I forgot to mention that you need to update database so that delete_bibliographic_records is added to database and is usable. Permission records_batchdel only allows user to use batch modification tool for records. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35953 --- Comment #18 from Emmanuel Bétemps <e.betemps@gmail.com> --- (In reply to Emmi Takkinen from comment #17)

There is a mention in test plan that you need to run updatedatabase.pl. If you're testing with sandbox it should be run automatically (if I have understood correctly how sandboxes work). If the permission is still not displayed after update then there is something wrong with these patches.

I understand where I'm wrong : I read and tried to run the test plan in comment 13 but you seem talking about the one in comment 11 (the step 'apply patch isn't always at the beginning of the test plan) I'm sorry but I must admit I'm a bit lost with all these test plans :) -- You are receiving this mail because: You are watching all bug changes.