https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15918 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15920 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15920 [Bug 15920] Clean up and fix errors in batch checkout template -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15918 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48375&action=edit Bug 15918 - Obsolete file datatables-strings.inc can be removed The include file datatables-strings.inc is no longer necessary. Its contents are now in datatables.inc. This patch corrects two references in comments to datatables-strings.inc (replacing it with datatables.inc) and removes the obsolete file. To test, apply the patch and load any page with a DataTables-enabled table configured to show pagination buttons, e.g. Saved Reports. Pagination labels like "Next," "Previous," and "Showing X of X..." should be correct. Search the codebase to confirm that no references remain for datatables-strings.inc. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15918 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48375|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 50294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50294&action=edit Bug 15918 - Obsolete file datatables-strings.inc can be removed The include file datatables-strings.inc is no longer necessary. Its contents are now in datatables.inc. This patch corrects two references in comments to datatables-strings.inc (replacing it with datatables.inc) and removes the obsolete file. To test, apply the patch and load any page with a DataTables-enabled table configured to show pagination buttons, e.g. Saved Reports. Pagination labels like "Next," "Previous," and "Showing X of X..." should be correct. Search the codebase to confirm that no references remain for datatables-strings.inc. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15918 --- Comment #4 from Marc Véron <veron@veron.ch> --- Created attachment 50295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50295&action=edit Bug 15918: (followup) Correct comment in koha-tmpl/opac-tmpl/bootstrap/js/datatables.js This followup changes comment in koha-tmpl/opac-tmpl/bootstrap/js/datatables.js line 3 to MSG_DT_* variables comes from datatables.inc -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15918 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50294|0 |1 is obsolete| | Attachment #50295|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50318&action=edit Bug 15918 - Obsolete file datatables-strings.inc can be removed The include file datatables-strings.inc is no longer necessary. Its contents are now in datatables.inc. This patch corrects two references in comments to datatables-strings.inc (replacing it with datatables.inc) and removes the obsolete file. To test, apply the patch and load any page with a DataTables-enabled table configured to show pagination buttons, e.g. Saved Reports. Pagination labels like "Next," "Previous," and "Showing X of X..." should be correct. Search the codebase to confirm that no references remain for datatables-strings.inc. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15918 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #0)

The include file datatables-strings.inc is no longer necessary. Its contents are now in datatables.inc. The last few references to it can be removed and the file deleted.

Not sure it has ever been used actually. -- You are receiving this mail because: You are watching all bug changes.