https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17304 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au, | |kyle.m.hall@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17304 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 55574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55574&action=edit Bug 17304: Introduce C4::Matcher::_get_match_keys unit tests This function is used in several places, but it's behaviour is not covered by tests, thus trying to patch it can be problematic without introducing regressions. This patch introduces unit tests for it, in the t/Matcher.t file. To test: - Apply the patch - Run: $ prove t/Matcher.t => SUCCESS: Tests pass - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17304 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55574|0 |1 is obsolete| | --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 55603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55603&action=edit Bug 17304: Introduce C4::Matcher::_get_match_keys unit tests This function is used in several places, but it's behaviour is not covered by tests, thus trying to patch it can be problematic without introducing regressions. This patch introduces unit tests for it, in the t/Matcher.t file. To test: - Apply the patch - Run: $ prove t/Matcher.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17304 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #55603|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 55648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55648&action=edit [PASSED QA] Bug 17304: Introduce C4::Matcher::_get_match_keys unit tests This function is used in several places, but it's behaviour is not covered by tests, thus trying to patch it can be problematic without introducing regressions. This patch introduces unit tests for it, in the t/Matcher.t file. To test: - Apply the patch - Run: $ prove t/Matcher.t => SUCCESS: Tests pass - Sign off :-D Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17304 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Tomas! -- You are receiving this mail because: You are watching all bug changes.