[Bug 6073] New: string missing for translation in acq.js
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 Bug #: 6073 Summary: string missing for translation in acq.js Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: paul.poulain@biblibre.com QAContact: koha-bugs@lists.koha-community.org there's strings that misses the _() for translation in acq.js -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff AssignedTo|henridamien@koha-fr.org |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 --- Comment #1 from Paul Poulain <paul.poulain@biblibre.com> 2011-04-05 16:04:02 UTC --- Created attachment 3713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=3713 proposed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-04-05 16:10:04 UTC --- Linked script files are not processed by the translation script are they? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Depends on| |4503 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-04-05 16:14:41 UTC --- Added connection to bug 4503: Javascript files in js directory are not translated -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3713|0 |1 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #3713|1 |0 is obsolete| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-13 17:46:55 UTC --- Does the sign-off mean that js files can now be translated using po files and Pootle? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 17:53:39 UTC --- (In reply to comment #4)
Does the sign-off mean that js files can now be translated using po files and Pootle?
Katrin, it's a minor patch. It allow two (2) strings to be translatable. Now those strings have to be extracted from .js file with a global strings update: translate update. I hasn't be done yet, since this patch isn't yet push, and so Pootle has not been updated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-05-13 18:26:45 UTC --- Sorry Frederic, I think there is a misunderstanding. I had filed bug 4503 a while back because the js files from the js directories were not going into po files for translation at all. I was asking if that happes now so that we can have strings for translations in the files. Some problems with those files have been solved by moving strings into the template files for translation. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 --- Comment #7 from Frédéric Demians <frederic@tamil.fr> 2011-05-13 19:26:01 UTC --- Katrin, it's my turn to be sorry. Bug 4503 is still here and so the patch for the above bug (#6073) will be useless. Strings from acq.js won't be extracted and put in .po file. It wouldn't hurt to put this patch, and, who knows, we can fix bug 4503 in a not too distant future... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> 2011-05-16 08:24:09 UTC --- frederic++ = this patch can be applied. It will do nothing until the 4503 has been fixed, but it does not depend on 4503. (ps: should I say "i'm sorry" too ? :D :D) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-09 16:17:23 UTC --- QA comment Very small patch, about strings. The result won't be visible until 4503 is fixed, but this one will have to be applied anyway. I mark it "passed QA" for those reasons, chris object or merge, thx -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #10 from Chris Cormack <chris@bigballofwax.co.nz> 2011-08-10 01:18:34 UTC --- Pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6073 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-26 18:57:08 UTC --- Can not be tested but does not seem to break anything. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org