http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- The date manipulations is a little bit (very ?) dirty. If someone can do that with another way, he's welcome :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell@ptfs-europe. | |com --- Comment #4 from Colin Campbell <colin.campbell@ptfs-europe.com> --- The date handling is wrong. dt_from_string returns a DateTime object. there is no need for the xxx_iso variables. if you need the date as a string in iso format you can retrieve that using DateTime's methods -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 12160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12160&action=edit Bug 8652: Followup: add a default value for date_from (In reply to comment #5)

I took the liberty of amending the Koha::DateUtils calls. I'm sure the logic could be further cleaned up. Requires testing

Thanks Colin. This followup adds a parameter for the output_pref routine and reintroduces the default value for date_from if no other one is present. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 --- Comment #8 from Paul Poulain <paul.poulain@biblibre.com> --- Created attachment 12312 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12312&action=edit Bug 8652: Followup: add a default value for date_from This patchis add a third parameter to the output_pref routine. It allows to specify the output string with or without the hours and minutes (%H:%M) Signed-off-by: MathildeF <mathilde.formery@ville-nimes.fr> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8652 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * both patches passes koha-qa.pl * 1st patch has a negligible side-effect risk, 2nd patch has a larger one * investigating patch 2 more deeply: - a new possible parameter is added to output_pref signature. Depending on it, the return is as previously, or with more information - for all calls to this sub, there is no change in the returned result - checking t/DateUtils.t = still OK after the test - however, it would be worth to have a test for this new parameter. I've added a small follow-up, that add 3 tests to t/DateUtils.t passed QA -- You are receiving this mail because: You are watching all bug changes.