[Bug 18731] New: Orders table slow to load for vendors with many orders
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug ID: 18731 Summary: Orders table slow to load for vendors with many orders Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some libraries may have hundreds of open orders for a vendor, depending on acqisitions workflow. At that number of open orders, the tables on parcel.pl take 10 to 20 seconds to load. To speed up the loading of this page and the data, we should convert the order tables from pre-loading all order data to ajax tables that load order data on an as needed basis. That way we are only pulling the data for the orders that are currently visible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18137 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 [Bug 18137] REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Orders table slow to load |Add a REST endpoint for |for vendors with many |vendor orders |orders | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a REST endpoint for |REST api: Add an endpoint |vendor orders |for vendor orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|REST api: Add an endpoint |REST api: Add an endpoint |for vendor orders |for acquisition orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Was a bit confused by the bug title - hope I made it a bit more clear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Depends on| |19196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 [Bug 19196] Add pagination helpers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19209 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19209 [Bug 19209] Koha::Objects should provide ->is_paged method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19234 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 [Bug 19234] Add query parameters handling helpers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Acquisitions |REST api QA Contact|testopia@bugs.koha-communit | |y.org | Summary|REST api: Add an endpoint |CRUD for acquisition orders |for acquisition orders | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19369, 19370 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369 [Bug 19369] Add a helper function for translating pagination params into SQL::Abstract https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370 [Bug 19370] Add a helper function for translating order_by params into SQL::Abstract -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug 18731 depends on bug 19209, which changed state. Bug 19209 Summary: Koha::Objects should provide ->is_paged method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19209 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19410 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410 [Bug 19410] Koha::Objects needs a ->search_for_api method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug 18731 depends on bug 18137, which changed state. Bug 18137 Summary: REST API: Migrate from Mojolicious::Plugin::Swagger2 to Mojolicious::Plugin::OpenAPI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18137 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69184&action=edit Bug 18731: WIP /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. It uses the new pagination and query parsing plugins. Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69185&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It adds query parameters definitions for the reserved params: - _match - _order_by - _page - _per_page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69184|0 |1 is obsolete| | --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69309&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. It uses the new pagination, query parsing and object searching plugins. Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69185|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69310&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It adds query parameters definitions for the reserved params: - _match - _order_by - _page - _per_page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19250 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250 [Bug 19250] Add pagination to /acquisitions/vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19250 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19250 [Bug 19250] Add pagination to /acquisitions/vendors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69310|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 69544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69544&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug 18731 depends on bug 19234, which changed state. Bug 19234 Summary: Add query parameters handling helpers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19234 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug 18731 depends on bug 19369, which changed state. Bug 19369 Summary: Add a helper function for translating pagination params into SQL::Abstract https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19369 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug 18731 depends on bug 19370, which changed state. Bug 19370 Summary: Add a helper function for translating order_by params into SQL::Abstract https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19370 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug 18731 depends on bug 19410, which changed state. Bug 19410 Summary: Add a helper function for generating object searches for the API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19410 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Chris Slone <cslone@camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone@camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CRUD for acquisition orders |Add routes for acquisition | |orders URL| |https://wiki.koha-community | |.org/wiki/Acquisitions_orde | |rs_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm writting a new RFC spec to be voted on a proper dev meeting. I will re-do this work based on that vote. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69309|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73959&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. It uses the new pagination, query parsing and object searching plugins. The attribute names are consistent with the voted RFC Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69544|0 |1 is obsolete| | --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 73960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73960&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It adds query parameters definitions for the reserved params: - _match - _order_by - _page - _per_page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug 18731 depends on bug 19196, which changed state. Bug 19196 Summary: Add pagination helpers https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19196 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73959|0 |1 is obsolete| | --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 78435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78435&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. It uses the new pagination, query parsing and object searching plugins. The attribute names are consistent with the voted RFC Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73960|0 |1 is obsolete| | --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 78436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78436&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It adds query parameters definitions for the reserved params: - _match - _order_by - _page - _per_page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |matthias.meusburger@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78435|0 |1 is obsolete| | --- Comment #12 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 84133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84133&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. It uses the new pagination, query parsing and object searching plugins. The attribute names are consistent with the voted RFC Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78436|0 |1 is obsolete| | --- Comment #13 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 84134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84134&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It adds query parameters definitions for the reserved params: - _match - _order_by - _page - _per_page Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #14 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- As far as I'm concerned, it works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20212 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 [Bug 20212] Slowness in Receiving in Acquisitions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec@gmail.com Status|Signed Off |Failed QA CC| |josef.moravec@gmail.com --- Comment #15 from Josef Moravec <josef.moravec@gmail.com> --- started testing: 1) we should generalize API controller to not repeat almost same code againg, this is nice prototype, but out of the scope of this report 2) basket_id description: "Basket this order is linked to. If ommited, a new basket is automatically created" It is not true, basket is not created 3) Tests are missing 4) Where mandatory parameter in body is missing on creation of object, api reports 500 "Something went wrong, check the logs". But the api client has no chance to know what is wrong here. This is probably true on more places in api, but i not tested it all now. anyway good start, thanks Tomas for working on that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #16 from Josef Moravec <josef.moravec@gmail.com> --- And last thing for now, qa tools are complaining: FAIL Koha/REST/V1/Acquisitions/Orders.pm FAIL pod =head3 without preceding higher level in file Koha/REST/V1/Acquisitions/Orders.pm =head2 without preceding higher level *** WARNING: FAIL pod coverage POD is missing for add POD is missing for delete POD is missing for get POD is missing for list POD is missing for update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84133|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84134|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 95054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95054&action=edit Bug 18731: Unit tests This patch implements unit tests for the orders endpoint. Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 95055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95055&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It matches the voted RFC. Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 95056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95056&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. The attribute names are consistent with the voted RFC To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Test the API with your favourite tool (Postman?) => SUCCESS: It works as expected! 4 Sign off :-D Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr, | |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24228 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24302 Status|Needs Signoff |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 [Bug 24302] Add a way to specify nested objects to embed in OpenAPI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24228 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24228 [Bug 24228] Add a parameter to recursively embed objects in Koha::Object(s)->to_api -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 [Bug 24321] Make objects.search use mappings from Koha::Object(s) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95056|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95055|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96853&action=edit Bug 18731: Make authenticate_api_request stash the embed structure -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96854&action=edit Bug 18731: Unit tests This patch implements unit tests for the orders endpoint. Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96855&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It matches the voted RFC. Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #23 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96856&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. The attribute names are consistent with the voted RFC To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Test the API with your favourite tool (Postman?) => SUCCESS: It works as expected! 4 Sign off :-D Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #24 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96857&action=edit Bug 18731: Add API mappings to K::A::{Basket,Invoice} This patch adds to_api_mapping definitions to the following classes: - Koha::Acquisition::Basket - Koha::Acquisition::Invoice They are implemented following the proposed RFCs: https://wiki.koha-community.org/wiki/Acquisitions_baskets_endpoint_RFC https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #25 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96858&action=edit Bug 18731: Use the stashed koha.embed in objects.search This patch makes the objects.search helper use the koha.embed structure that is embedded in the authenticate_api_request step. This way, any controller using it will benefit from automatic embed handling. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I've set this back to NSO as I introduced some important changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96857|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96858|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96916&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. The attribute names are consistent with the voted RFC To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Test the API with your favourite tool (Postman?) => SUCCESS: It works as expected! 4 Sign off :-D Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96917&action=edit Bug 18731: Add API mappings to K::A::{Basket,Invoice} This patch adds to_api_mapping definitions to the following classes: - Koha::Acquisition::Basket - Koha::Acquisition::Invoice They are implemented following the proposed RFCs: https://wiki.koha-community.org/wiki/Acquisitions_baskets_endpoint_RFC https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96918&action=edit Bug 18731: Use the stashed koha.embed in objects.search This patch makes the objects.search helper use the koha.embed structure that is embedded in the authenticate_api_request step. This way, any controller using it will benefit from automatic embed handling. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96855|0 |1 is obsolete| | --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 96938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96938&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It matches the voted RFC. Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96853|0 |1 is obsolete| | Attachment #96854|0 |1 is obsolete| | Attachment #96916|0 |1 is obsolete| | Attachment #96917|0 |1 is obsolete| | Attachment #96918|0 |1 is obsolete| | Attachment #96938|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96961&action=edit Bug 18731: Make authenticate_api_request stash the embed structure Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96962&action=edit Bug 18731: Unit tests This patch implements unit tests for the orders endpoint. Sponsored-by: Camden County Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #33 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96963&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. The attribute names are consistent with the voted RFC To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Test the API with your favourite tool (Postman?) => SUCCESS: It works as expected! 4 Sign off :-D Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #34 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96964&action=edit Bug 18731: Add API mappings to K::A::{Basket,Invoice} This patch adds to_api_mapping definitions to the following classes: - Koha::Acquisition::Basket - Koha::Acquisition::Invoice They are implemented following the proposed RFCs: https://wiki.koha-community.org/wiki/Acquisitions_baskets_endpoint_RFC https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96965&action=edit Bug 18731: Use the stashed koha.embed in objects.search This patch makes the objects.search helper use the koha.embed structure that is embedded in the authenticate_api_request step. This way, any controller using it will benefit from automatic embed handling. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 96966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96966&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It matches the voted RFC. Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|josef.moravec@gmail.com |martin.renvoize@ptfs-europe | |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This is an impressive culmination of work. There's little chance of introducing regressions here and in my testing everything appears to work as expected. Passing QA and Pushing.. lets see if anything drops out of it when we start to use the endpoints in earnest :) Well done everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96961|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97107&action=edit Bug 18731: Make authenticate_api_request stash the embed structure Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96962|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97108&action=edit Bug 18731: Unit tests This patch implements unit tests for the orders endpoint. Sponsored-by: Camden County Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96963|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97109&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. The attribute names are consistent with the voted RFC To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Test the API with your favourite tool (Postman?) => SUCCESS: It works as expected! 4 Sign off :-D Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96964|0 |1 is obsolete| | --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97110&action=edit Bug 18731: Add API mappings to K::A::{Basket,Invoice} This patch adds to_api_mapping definitions to the following classes: - Koha::Acquisition::Basket - Koha::Acquisition::Invoice They are implemented following the proposed RFCs: https://wiki.koha-community.org/wiki/Acquisitions_baskets_endpoint_RFC https://wiki.koha-community.org/wiki/Acquisitions_invoices_endpoint_RFC Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96965|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97111&action=edit Bug 18731: Use the stashed koha.embed in objects.search This patch makes the objects.search helper use the koha.embed structure that is embedded in the authenticate_api_request step. This way, any controller using it will benefit from automatic embed handling. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #96966|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97112&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It matches the voted RFC. Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #44 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 97113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97113&action=edit Bug 18731: (QA follow-up) Spelling and POD corrections Just a coulpe of very minor tweaks to keep the QA scripts happy Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #45 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #46 from Chris Slone <cslone@camdencountylibrary.org> --- This is really great to see! Is it able to be backported to 19.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #47 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The new test is failing (randomly?) t/db_dependent/Koha/REST/Plugin/Objects.t .. 1/3 # Failed test 'exact match for JSON Pointer "/0"' # at t/db_dependent/Koha/REST/Plugin/Objects.t line 174. # Structures begin differing at: # $got->{fund}{budget_id} = '534289848' # $expected->{fund}{budget_id} = Does not exist Koha_Master_D9_My8 run 76 It's not related to My8, I recreate locally with MariaDB latest. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #47)
The new test is failing (randomly?)
t/db_dependent/Koha/REST/Plugin/Objects.t .. 1/3 # Failed test 'exact match for JSON Pointer "/0"' # at t/db_dependent/Koha/REST/Plugin/Objects.t line 174. # Structures begin differing at: # $got->{fund}{budget_id} = '534289848' # $expected->{fund}{budget_id} = Does not exist
Koha_Master_D9_My8 run 76
It's not related to My8, I recreate locally with MariaDB latest.
I really like it when tests serve the purpose :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #49 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 97331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97331&action=edit Bug 18731: Overload K::A::Fund->to_api to avoid conflict This patch overloads the to_api methods on the Fund class, so conflicting (on mapping) attribute names are not a problem. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/Koha/Acquisition/Fund.t \ t/db_dependent/Koha/REST/Plugin/Objects.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This development adds API release notes| |routes to perform CRUD | |operation on acquisition | |order lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #50 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Followup pushed, thanks Tomas -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24457 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457 [Bug 24457] K::A::Basket->to_api is not passing the parameters to the parent class implementation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24459 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24459 [Bug 24459] Overloaded ->to_api needs to pass $params through -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24462 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |joy@bywatersolutions.com --- Comment #51 from Joy Nelson <joy@bywatersolutions.com> --- Enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24611 [Bug 24611] wrong budget_id query parameter in /acquisitions/orders -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug 18731 depends on bug 24321, which changed state. Bug 24321 Summary: Make objects.search use mappings from Koha::Object(s) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24321 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Bug 18731 depends on bug 24302, which changed state. Bug 24302 Summary: Add a way to specify nested objects to embed in OpenAPI https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24302 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |25513 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25513 [Bug 25513] acquisitions_orders.t is failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28248 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28248 [Bug 28248] Exception when getting all orders -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org