https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16759 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16759 [Bug 16759] Make opac holdings table configurable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 65518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65518&action=edit Bug 19038: Remove the OPACShowBarcode syspref This patch removes the OPACShowBarcode syspref in favour of the new columns settings option introduced by bug 16759. On the upgrade step, it picks the value for OPACShowBarcode and uses it to populate the columns_settings table. To test: - Verify the upgrade process maintains the current behaviour Regards Sponsored-by: Dover -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65518|0 |1 is obsolete| | --- Comment #2 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 66133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66133&action=edit Bug 19038: Remove the OPACShowBarcode syspref Followed test plan and works as expected. Functionality of patch from bug 16759 appears intact too. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |In Discussion --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- I think this one is good, however, what I see is that the upgrade is odd. If you have set columns configuration already, this won't set it regardless of syspref so if pref is set to "Don't show" and columns setting is set to show barcode then after this patch the column will show(it was hidden before) I don't know if this matters if both bugs are pushed to same version, can you answer Tomas? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68489&action=edit Bug 19038: QA Followup - Hide barcode column by default (as syspref default is hide) Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19038 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.