[Bug 11205] New: The datatables filtering does not work when several tables exist
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Bug ID: 11205 Summary: The datatables filtering does not work when several tables exist Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org If there are more than 1 table on the same page, the datatable filters don't work. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion Assignee|gmcharlt@gmail.com |jonathan.druart@biblibre.co | |m Summary|The datatables filtering |The datatables filters |does not work when several |don't work when several |tables exist |tables exist -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22739&action=edit Bug 11205: The datatables filtering does not work when several tables exist If there are more than 1 table on the same page, the datatable filters don't work. Test plan: 1/ Go on serials/serials-search.pl?searched=1 2/ filter on a column for opened subscriptions => the closed subscriptions should not be filtered. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22739|0 |1 is obsolete| | --- Comment #2 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 22744 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22744&action=edit [SIGNED-OFF] Bug 11205: The datatables filtering does not work when several tables exist If there are more than 1 table on the same page, the datatable filters don't work. Test plan: 1/ Go on serials/serials-search.pl?searched=1 2/ filter on a column for opened subscriptions => the closed subscriptions should not be filtered. Works! Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- If I click on one of the titles in the table where expiration date is blank, the following error occurs: Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /usr/share/koha/testclone/C4/Serials.pm line 2380 Could you confirm? If so, we should open a new report for that one.. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- I have a hard time to reproduce the error :) Somehow the filter on Open and Closed seems to work (also after refreshing) with and without this patch. Could you please clarify what you exactly mean with "more than 1 table on the page"? Or provide some more detailed steps to reproduce the problem encountered? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Marcel, the only page with 2 tables is serials/serials-search.pl?searched=1 There are 2 tabs: opened and closed subscriptions. On each tabs there is a table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #3)
If I click on one of the titles in the table where expiration date is blank, the following error occurs:
Date::Calc::PP::Delta_Days(): Usage: Date::Calc::Delta_Days($year1,$month1,$day1,$year2,$month2,$day2) at /usr/share/koha/testclone/C4/Serials.pm line 2380
Could you confirm? If so, we should open a new report for that one..
I think it is not introduced by this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- It would have been helpful to be somewhat more descriptive than just say "filters don't work". This could save some time in understanding what exactly the problem is. Your problem apparently was: If I filter on for instance a title word on the first tab (Opened), this filter should not be applied to the second tab (Closed). Your patch does resolve this situation. Thanks for that. No complaints from qa tools too. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 --- Comment #8 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 22758 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22758&action=edit Bug 11205: The datatables filtering does not work when several tables exist If there are more than 1 table on the same page, the datatable filters don't work. Test plan: 1/ Go on serials/serials-search.pl?searched=1 2/ filter on a column for opened subscriptions => the closed subscriptions should not be filtered. Works! Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22744|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 --- Comment #9 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to M. de Rooy from comment #7)
It would have been helpful to be somewhat more descriptive than just say "filters don't work". This could save some time in understanding what exactly the problem is. Your problem apparently was: If I filter on for instance a title word on the first tab (Opened), this filter should not be applied to the second tab (Closed). Your patch does resolve this situation. Thanks for that.
Sorry Marcel, I thought step 2 of the test plan explained that clearly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11205 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master and 3.14.x. Thanks, Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org