[Bug 38390] New: Add 'subscriptions+count' embed to vendors endpoint
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Bug ID: 38390 Summary: Add 'subscriptions+count' embed to vendors endpoint Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: kyle@bywatersolutions.com, matt.blenkinsop@ptfs-europe.com, testopia@bugs.koha-community.org, tomascohen@gmail.com Depends on: 38011 Blocks: 38010 This was created as a need for the Vendors Vue rework.. we initially tried to go all the way and allow embedding 'subscriptions', but that proved a larger piece of work. For the Vendors UI we only actually need the count of subscriptions for now so we can just embed that. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38010 [Bug 38010] Migrate vendors to Vue https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38011 [Bug 38011] Add a foreign key link between vendors and subscriptions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 174192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174192&action=edit Bug 38390: Add subscriptions+count to vendors embed This patch adds the subscriptions+count option to the embeddable enum for the /vendors endpoint. Test plan 1) Inspect the change to t/db_dependant/api/v1/acquisitions_vendors.t and confirm it's testing for the addition of subscriptions_count. 2) Run the above tests and confirm it passes Note: For the above tests to pass, you will need to ensure your api bundle is rebuilt after the patches are applied and restart plack. `yarn build && restart_all` in ktd -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |roadmap_24_11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174192|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 174238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174238&action=edit Bug 38390: Add subscriptions+count to vendors embed This patch adds the subscriptions+count option to the embeddable enum for the /vendors endpoint. Test plan 1) Inspect the change to t/db_dependant/api/v1/acquisitions_vendors.t and confirm it's testing for the addition of subscriptions_count. 2) Run the above tests and confirm it passes Note: For the above tests to pass, you will need to ensure your api bundle is rebuilt after the patches are applied and restart plack. `yarn build && restart_all` in ktd Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174238|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 174361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174361&action=edit Bug 38390: Add subscriptions+count to vendors embed This patch adds the subscriptions+count option to the embeddable enum for the /vendors endpoint. Test plan 1) Inspect the change to t/db_dependant/api/v1/acquisitions_vendors.t and confirm it's testing for the addition of subscriptions_count. 2) Run the above tests and confirm it passes Note: For the above tests to pass, you will need to ensure your api bundle is rebuilt after the patches are applied and restart plack. `yarn build && restart_all` in ktd Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *PTFS release notes| |Europe* and *ByWater | |Solutions* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.06 released in| | --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Keywords|roadmap_24_11 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Note that Bug 38011 not in 24.05.x Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |david@davidnind.com Resolution|--- |FIXED --- Comment #7 from David Nind <david@davidnind.com> --- No updates requried to the manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38390 Bug 38390 depends on bug 38011, which changed state. Bug 38011 Summary: Add a foreign key link between vendors and subscriptions https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38011 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org