http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7270 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Status|NEW |ASSIGNED Patch Status|--- |Needs Signoff AssignedTo|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-28 13:01:35 UTC --- Patch also fills noItemTypeImages for the template; it was not initialized in the script. Test this patch by double clicking a list name in Staff client/Lists. Before this patch you see a double item type description in the table. After this patch, depending on the value of pref noItemTypeImages you will see either an icon or a single description. (Check it by toggling that value. Note that you may have to add icons to your itemtypes in Administration.) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7270 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-11-28 14:08:29 UTC --- I'm assuming item-level itemtypes must be disabled in order for this bug to manifest? I can see three situations where one might see a broken itemtype image (with item-level itemtypes disabled): 1. The title has no biblio-level itemtype set. 2. The itemtype is set but it has no image specified. 3. The itemtype has a remote image specified and the remote image doesn't exist. 1 & 2 can be solved by wrapping the <img> tag in a check for imageurl 3 might be solved by this patch but I think it's a rare enough case that we shouldn't implement the fix proposed here because it removes the output of the description along with the image. As far as I know that is the intention of the way the templates have been set up here and elsewhere. To change that I think we need a wider discussion. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7270 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-11-28 14:28:07 UTC --- (In reply to comment #4)

Furthermore it was built on the assumption that you do not need the text if the image is displayed. But you do?

In this case and in other places in the templates it is designed so that image and text will appear together. Whether or not this *should* be the way it is done could be the subject of a mailing list discussion, but for now I think we should keep things consistent. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7270 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-30 15:40:13 UTC --- The noItemTypeImages variable is already filled in Auth.pm. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7270 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6473|0 |1 is obsolete| | --- Comment #9 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-30 15:50:55 UTC --- Created attachment 6474 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6474 Revised patch And even then attaching the wrong file ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7270 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7270 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7270 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 Patch Status|Signed Off |Patch Pushed -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.