[Bug 15832] New: Pending reserves: duplicates branches in datatable filter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Bug ID: 15832 Summary: Pending reserves: duplicates branches in datatable filter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: alex.arnaud@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In the datatable of pending reserves, if a title has several branches, this cause duplicates in the filter select. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 --- Comment #1 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 48141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48141&action=edit Bug 15832 - Fix items split-up in pendingreserves.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48141|0 |1 is obsolete| | --- Comment #2 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 48497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48497&action=edit Bug 15832 - Fix items split-up in pendingreserves.tt Test plna: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), -check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - libraries filter should not contain duplicate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48497|0 |1 is obsolete| | --- Comment #3 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 48694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48694&action=edit Bug 15832 - Fix items split-up in pendingreserves.tt Test plna: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), -check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - libraries filter should not contain duplicate. Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com Assignee|koha-bugs@lists.koha-commun |alex.arnaud@biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- The patch removes the duplicates but does not fix the filter. If you have: ---- L1 L2 ---- L1 ---- L2 L3 and you select the L2 filter, you will only see the 3rd line if you select L3, all lines will be hidden. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 David Roberts <david.roberts@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david.roberts@ptfs-europe.c | |om --- Comment #5 from David Roberts <david.roberts@ptfs-europe.com> --- Tested this on a customer's system at 3.22. The duplicate libraries still display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48694|0 |1 is obsolete| | --- Comment #6 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 49682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49682&action=edit Bug 15832 - Fix filter and items split-up in pendingreserves.tt Test plan: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), -check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - check that libraries filter should not contain duplicate, - check that the filter works. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49682|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 49870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49870&action=edit [SIGNED-OFF] Bug 15832 - Fix filter and items split-up in pendingreserves.tt Test plan: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), - Check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - check that libraries filter should not contain duplicate, - check that the filter works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49892&action=edit Bug 15832 - Fix filter and items split-up in pendingreserves.tt Test plan: - Go to circ/pendingreserves.pl (Ensure that there are biblios with many items on different branches), - Check the libraries filter at the bottom of datatable. There should be duplicates. - Apply this patch and return to circ/pendingreserves.pl, - check that libraries filter should not contain duplicate, - check that the filter works. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49893&action=edit Bug 15832: Remove empty string from the filters On each cell, the split will generate a new empty entry. This patch removes that entry. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Attachment #49870|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #12 from Frédéric Demians <frederic@tamil.fr> --- Pushed to 3.22.x, will be in 3.20.11. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15832 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|nengard@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org