[Bug 33000] New: Use template wrapper for breadcrumbs: Acquisitions part 1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Bug ID: 33000 Summary: Use template wrapper for breadcrumbs: Acquisitions part 1 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update some templates in acquisitions so that they use the new template wrapper for breadcrumbs. - acqui-home.tt - addorderiso2709.tt - basket.tt - basketgroup.tt - basketheader.tt - booksellers.tt - cancelorder.tt - duplicate_orders.tt - edi_ean.tt - edifactmsgs.tt - edimsg.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 146899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146899&action=edit Bug 33000: Use template wrapper for breadcrumbs: Acquisitions part 1 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions home - Vendor search results - Basket details - Cancel order - Create EDIFACT order - Basket edit - Basket deletion confirmation - Add to basket - From a staged MARC file - From existing orders (copy) - Basket groups (create, edit) - EDIFACT messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146899|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 147094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147094&action=edit Bug 33000: Use template wrapper for breadcrumbs: Acquisitions part 1 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions home - Vendor search results - Basket details - Cancel order - Create EDIFACT order - Basket edit - Basket deletion confirmation - Add to basket - From a staged MARC file - From existing orders (copy) - Basket groups (create, edit) - EDIFACT messages Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I think I am too late to the party, but I would like to raise a couple of things: 1. We should surround the strings with span, or the translation script will add awful strings with lot of %s. Example: . %1$s: END. #. %2$s: WRAPPER breadcrumb_item bc_active=1. #. %3$s: END. #. %4$s: END. #. %5$s: IF ( else ). #. %6$s: WRAPPER breadcrumb_item bc_active=1. #. %7$s: END. #. %8$s: END. #. %9$s: END #/ WRAPPER breadcrumbs. #. %10$s: END #/ WRAPPER sub-header.inc. #: koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqcontract.tt:69 msgid "%s %s Contract deleted %s %s %s %s Contracts %s %s %s %s " 2. In the same template (aqcontract), I see: [% IF ( add_validate ) %] [% WRAPPER breadcrumb_item %] <a href="/cgi-bin/koha/admin/aqcontract.pl?booksellerid=[% booksellerid | uri %]">Contracts</a> [% END %] [% WRAPPER breadcrumb_item bc_active=1 %] Data recorded [% END %] [% END %] [% IF ( delete_confirm ) %] [% WRAPPER breadcrumb_item %] <a href="/cgi-bin/koha/admin/aqcontract.pl?booksellerid=[% booksellerid | uri %]">Contracts</a> [% END %] [% WRAPPER breadcrumb_item bc_active=1 %] Confirm deletion of contract [% contractnumber | html %] [% END %] [% END %] [% IF ( delete_confirmed ) %] [% WRAPPER breadcrumb_item %] <a href="/cgi-bin/koha/admin/aqcontract.pl?booksellerid=[% booksellerid | uri %]">Contracts</a> [% END %] [% WRAPPER breadcrumb_item bc_active=1 %] Contract deleted [% END %] [% END %] [% IF ( else ) %] [% WRAPPER breadcrumb_item bc_active=1 %] Contracts [% END %] [% END %] I can we should improve that we avoid repetition. We should only need something like: [% WRAPPER breadcrumb_item remove_link=else%] <a href="/cgi-bin/koha/admin/aqcontract.pl?booksellerid=[% booksellerid | uri %]">Contracts</a> [% END %] [% IF ( add_validate ) %] [% WRAPPER breadcrumb_item bc_active=1 %] Data recorded [% END %] [% END %] [% IF ( delete_confirm ) %] [% WRAPPER breadcrumb_item bc_active=1 %] Confirm deletion of contract [% contractnumber | html %] [% END %] [% END %] [% IF ( delete_confirmed ) %] [% WRAPPER breadcrumb_item bc_active=1 %] Contract deleted [% END %] [% END %] I don't know how hard it would be to implement 2, but 1 looks blocker to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 147275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147275&action=edit Bug 33000: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> This follow-up includes a change to admin/cities.tt as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33007 [Bug 33007] Use template wrapper for breadcrumbs: Administration part 2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147275|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 147615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147615&action=edit Bug 33000: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> This follow-up includes a change to admin/cities.tt as well. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147094|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147746&action=edit Bug 33000: Use template wrapper for breadcrumbs: Acquisitions part 1 This patch updates several acquisitions-related templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Acquisitions home - Vendor search results - Basket details - Cancel order - Create EDIFACT order - Basket edit - Basket deletion confirmation - Add to basket - From a staged MARC file - From existing orders (copy) - Basket groups (create, edit) - EDIFACT messages Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147615|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147747&action=edit Bug 33000: (follow-up) Add spans for translatability This patch finds places in the updated breadcrumbs markup where a translatable string is isolated in a way that makes it hard for the translation script to find it, and wraps these strings with <span> This follow-up includes a change to admin/cities.tt as well. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Nice work everyone! Pushed to stable for 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Bug 33000 depends on bug 32507, which changed state. Bug 32507 Summary: Use template wrapper to build breadcrumb navigation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33000 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to stable |RESOLVED --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 22.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org