[Bug 17430] New: MarkIssueReturned.t should create its own data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17430 Bug ID: 17430 Summary: MarkIssueReturned.t should create its own data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: tomascohen@gmail.com QA Contact: gmcharlt@gmail.com It just doesn't. To reproduce: - Have a category created with categorycode = C - Run: $ prove t/db_dependent/Circulation/MarkIssueReturned.t => FAIL: primary key issues on the DB -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17430 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17430 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 56233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56233&action=edit Bug 17430: Make MarkIssueReturned.t create its own data This patch makes MarkIssueReturned.t use t::lib::TestBuilder to create the data it needs. To test: - On master, have a category with categorycode = C - Run: $ prove t/db_dependent/Circulation/MarkIssueReturned.t => FAIL: primary key problems make the tests fail - Apply the patch - Run: $ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests are green! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17430 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17430 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17430 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56233|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56237&action=edit Bug 17430: Make MarkIssueReturned.t create its own data This patch makes MarkIssueReturned.t use t::lib::TestBuilder to create the data it needs. To test: - On master, have a category with categorycode = C - Run: $ prove t/db_dependent/Circulation/MarkIssueReturned.t => FAIL: primary key problems make the tests fail - Apply the patch - Run: $ prove t/db_dependent/Circulation/MarkIssueReturned.t => SUCCESS: Tests are green! - Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17430 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Trivial changes, skipping QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17430 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #4 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17430 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr Status|Pushed to Master |Pushed to Stable --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.05. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org