[Bug 40159] New: When modifying a subscription with received issues, prediction pattern doesn't start from next issue date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 Bug ID: 40159 Summary: When modifying a subscription with received issues, prediction pattern doesn't start from next issue date Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: arthur.suzuki@biblibre.com QA Contact: testopia@bugs.koha-community.org To reproduce the issue : Make a record and create a subscription for this record with a week or month subscription length and a first issue date in the past (like 2016). Receive at least one issue. Edit the subscription and test the prediction pattern. The displayed prediction shows only one number (unless you set the subscription length for like a thousand issues). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 --- Comment #1 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 183320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183320&action=edit Bug 40159: Fix prediction pattern when editing an ongoing subscription Test plan : - Without the patch, create a subscription for a record with weekly or monthly subscription length and a first acquisition date long ago. - Receive at least one issue for this subscription. - Edit the subscription and set the next acquisition date to today. - Check that testing the prediction pattern doesnt show the number of issues set in the subscription length (less issues). - Apply patch - Test the prediction pattern again, it will show the proper number of issues. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 Esther Melander <esther.melander@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |esther.melander@bywatersolu | |tions.com --- Comment #2 from Esther Melander <esther.melander@bywatersolutions.com> --- I tried testing this bug and I'm not sure I'm seeing what is described before the patch is applied. I tried creating a subscription without the patch, tested the numbering pattern and had the correct number of issues. Would it be possible to get an example screenshot of the subscription settings that do not show the correct number of issues when tested? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 --- Comment #3 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 184808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184808&action=edit renewal doesn't show the proper number of issues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 --- Comment #4 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 184809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184809&action=edit another example -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 --- Comment #5 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hi Esther, The problem occurs when selecting "months" or "weeks" rather than "number of issues" when trying the numbering pattern. Best, Arthur -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17656 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26054 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 --- Comment #6 from Mathieu Saby <mathsabypro@gmail.com> --- The behaviour of prediction models remains a bottomless mystery to me, and the manual isn't much help. Maybe I'm not knowledgeable enough on the subject, but I've just tested it and can't see any difference between the behaviour with and without the patch. Here's a screenshot.
From the manuel I read that the « 1st issue publication date » is the « date from which the prediction pattern will start »
1st issue publication date : June 1st 2024 Frequency : 1/month Subscription length : 12 months Subscription start date : 01/01/2025 Subscription start date : blank Numbering pattern : Volume, number Parameters for the prediction pattern : - Begins with VOLUME = 2024 ; Number = 6 (it must fit the information about the 1st issue used for calculating the predicton pattern, so june 2024) - Inner counter = 5 (because before june 2024, 5 issues have been published) The prediction pattern seems the same with and without the patch, and seems correct But when I try to receive an actual issue, Koha expect the issue « Vol 2024, No. 6 » published on « 06/01/2024 » and expected on « 06/01/2024 ». Same behavior with and without the patch. If my subscription begins the 01/01/2025, should not Koha expect as the 1st issue the « Vol. 2025, no. 1 » ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 --- Comment #7 from Mathieu Saby <mathsabypro@gmail.com> --- Created attachment 188125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188125&action=edit screenshot for comment 6 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 --- Comment #8 from Mathieu Saby <mathsabypro@gmail.com> --- Sorry, I was so focused on understanding the module that I didn't read the test plan carefully or understand the problem that was raised! I'll check now to see what happens if an issue has been received. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 --- Comment #9 from Mathieu Saby <mathsabypro@gmail.com> --- I suppose when you wrote "set the next acquisition date to today" you were making reference to the "Set the date received to today?" button while "multireceving" issues ? Reception date is not the same thing as aquisition date. It is hard to know how Koha is **supposed** to work. The multireceiving feature is not in the manual, not to speak of the "Set the date received to today?" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 --- Comment #10 from Mathieu Saby <mathsabypro@gmail.com> --- The manual does not specify how Koha should behave if the date of the first issue is earlier than the subscription start date. Are we sure that this type of configuration is allowed? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40159 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laurence.rault@biblibre.com --- Comment #11 from Laurence Rault <laurence.rault@biblibre.com> --- Tested on sandbox : I don't see the problem without the patch : after having received an item, the prediction pattern starts from the next waiting issue and displays all the issues for the subscription period. Tested with frequencies 1/month, 2/month. With the patch, no change. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org