[Bug 16907] New: Move DelMember and HandleDelBorrower to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Bug ID: 16907 Summary: Move DelMember and HandleDelBorrower to Koha::Patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16890, 16891 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16890 [Bug 16890] TestBuilder always generate datetime for dates https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16891 [Bug 16891] Move MoveMemberToDeleted to Koha::Patron->move_to_deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53327&action=edit Bug 16907: Koha::Patrons - Move DelMember to ->delete This patch moves the C4::Members::DelMember subroutine to the Koha::Patron module. The delete method must be overwritten to permit handling of patron's holds. Test plan: (With the 2 patches applied) 1/ Create a patron with holds and owner of lists 2/ Delete patrons using the web interface: - More > Delete on a patron page - Batch patron deletion tools 3/ and the cronjob script - perl misc/cronjobs/delete_patrons.pl -c [more options] The patron should have been moved to the deletedborrowers table, his/her holds and lists should have been deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53328&action=edit Bug 16907: Koha::Patrons - Move HandleDelBorrower to ->delete This job should be done each time patron data are deleted. It's better to do it just before deleting the patron than assuming the caller did the job by itself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53327|0 |1 is obsolete| | Attachment #53328|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53523&action=edit Bug 16907: Koha::Patrons - Move DelMember to ->delete This patch moves the C4::Members::DelMember subroutine to the Koha::Patron module. The delete method must be overwritten to permit handling of patron's holds. Test plan: (With the 2 patches applied) 1/ Create a patron with holds and owner of lists 2/ Delete patrons using the web interface: - More > Delete on a patron page - Batch patron deletion tools 3/ and the cronjob script - perl misc/cronjobs/delete_patrons.pl -c [more options] The patron should have been moved to the deletedborrowers table, his/her holds and lists should have been deleted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 53524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53524&action=edit Bug 16907: Koha::Patrons - Move HandleDelBorrower to ->delete This job should be done each time patron data are deleted. It's better to do it just before deleting the patron than assuming the caller did the job by itself. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 54184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54184&action=edit Bug 16907: Make sure the log will be written only if the patron has been deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53523|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 54401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54401&action=edit Bug 16907: Koha::Patrons - Move DelMember to ->delete This patch moves the C4::Members::DelMember subroutine to the Koha::Patron module. The delete method must be overwritten to permit handling of patron's holds. Test plan: (With the 2 patches applied) 1/ Create a patron with holds and owner of lists 2/ Delete patrons using the web interface: - More > Delete on a patron page - Batch patron deletion tools 3/ and the cronjob script - perl misc/cronjobs/delete_patrons.pl -c [more options] The patron should have been moved to the deletedborrowers table, his/her holds and lists should have been deleted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #53524|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 54402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54402&action=edit Bug 16907: Koha::Patrons - Move HandleDelBorrower to ->delete This job should be done each time patron data are deleted. It's better to do it just before deleting the patron than assuming the caller did the job by itself. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54184|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 54403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54403&action=edit Bug 16907: Make sure the log will be written only if the patron has been deleted Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Nice work, Jonathan. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54401|0 |1 is obsolete| | Attachment #54402|0 |1 is obsolete| | Attachment #54403|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56342&action=edit Bug 16907: Koha::Patrons - Move DelMember to ->delete This patch moves the C4::Members::DelMember subroutine to the Koha::Patron module. The delete method must be overwritten to permit handling of patron's holds. Test plan: (With the 2 patches applied) 1/ Create a patron with holds and owner of lists 2/ Delete patrons using the web interface: - More > Delete on a patron page - Batch patron deletion tools 3/ and the cronjob script - perl misc/cronjobs/delete_patrons.pl -c [more options] The patron should have been moved to the deletedborrowers table, his/her holds and lists should have been deleted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56343&action=edit Bug 16907: Koha::Patrons - Move HandleDelBorrower to ->delete This job should be done each time patron data are deleted. It's better to do it just before deleting the patron than assuming the caller did the job by itself. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 56344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56344&action=edit Bug 16907: Make sure the log will be written only if the patron has been deleted Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56342|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56419&action=edit [PASSED QA] Bug 16907: Koha::Patrons - Move DelMember to ->delete This patch moves the C4::Members::DelMember subroutine to the Koha::Patron module. The delete method must be overwritten to permit handling of patron's holds. Test plan: (With the 2 patches applied) 1/ Create a patron with holds and owner of lists 2/ Delete patrons using the web interface: - More > Delete on a patron page - Batch patron deletion tools 3/ and the cronjob script - perl misc/cronjobs/delete_patrons.pl -c [more options] The patron should have been moved to the deletedborrowers table, his/her holds and lists should have been deleted. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56420&action=edit [PASSED QA] Bug 16907: Koha::Patrons - Move HandleDelBorrower to ->delete This job should be done each time patron data are deleted. It's better to do it just before deleting the patron than assuming the caller did the job by itself. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 56421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56421&action=edit [PASSED QA] Bug 16907: Make sure the log will be written only if the patron has been deleted Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Attachment #56344|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56343|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another tree bites the dust :) Thanks Jonathan -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16907 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org