[Bug 20001] New: ILL: Adding a 'new request' from OPAC is not possible
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Bug ID: 20001 Summary: ILL: Adding a 'new request' from OPAC is not possible Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de The button to add a 'new request' from the OPAC doesn't work, it doesn't matter if there is one or multiple backends installed: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?method=create&backend=ARRAY(0xa943760) Internal server error Can't locate Koha/Illbackends/ARRAY(0xb154640)/Base.pm in @INC (you may need to install the Koha::Illbackends::ARRAY(0xb154640)::Base module) (@INC contains: /home/vagrant/kohaclone /home/vagrant/kohaclone/installer /home/vagrant/kohaclone/lib/installer /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2 /usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20 /usr/local/lib/site_perl .) at /home/vagrant/kohaclone/Koha/Illrequest.pm line 153. When there are mulitple backends installed the button is a menu on the staff side that lets you pick, what you want to do. I think the same should probably happen on the OPAC. Marking critical for ILL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker Summary|ILL: Adding a 'new request' |ILL: Adding a 'new request' |from OPAC is not possible |is not possible --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Actually it's the same from the staff side. The button is nicer, but once you click on it, it breaks: Button: http://localhost:8081/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=FreeForm Internal server error Template process failed: file error - : not found at /home/vagrant/kohaclone/C4/Templates.pm line 122. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've followed installation instructions on bug 20001 comment20 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Francesco Rivetti <oha@oha.it> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oha@oha.it --- Comment #3 from Francesco Rivetti <oha@oha.it> --- in our implementation (NNCIP) the creation of a new request come from a xml requests on a different component. The backend properly create the request and everything else work reasonably fine. It's probable than that the issue is on the user interface HTH -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset@biblibre.co | |m --- Comment #4 from Victor Grousset/tuxayo <victor.grousset@biblibre.com> --- (In reply to Katrin Fischer from comment #2)
I've followed installation instructions on bug 20001 comment20
bug 20001 comment20? 20001 is this bug and there aren't 20 comments. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, bug 7317 comment 20 I have tested on master, maybe it works on 17.11? I haven't had time to verify this yet. The problem appears in the GUI, I think your .it implementation is not listed on the wiki, so can't test. Dummy and FreeForm don't work. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, silly me. I don't know exactly what happened yet, but I somehow managed to end up with empty Illbackends directories after the initial cloning (had checked contents then). So it's right, Base.pm was absolutely not there. I think some unintentional git magic. There is no RESOLVED SILLYME, so picking INVALID :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILL: Adding a 'new request' |ILL: Adding a 'new request' |is not possible |from OPAC is not possible Status|RESOLVED |REOPENED Resolution|INVALID |--- --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The problem with the broken button in OPAC remains: http://localhost:8080/cgi-bin/koha/opac-illrequests.pl?method=create&backend=ARRAY(0xa943760) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This appears to get the split button in OPAC working, not a good fix, but a clue on how to fix it maybe: <div id="illrequests-create-button" class="dropdown btn-group"> - [% IF backends.size > 1 %] + [% IF backends.0.size > 1 %] [...] Now stuck with: Template process failed: file error - : not found at /home/vagrant/kohaclone/C4/Templates.pm line 122. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70696&action=edit Bug 20001: Fix confusion between array and arrayref Illrequest->available_backends always returned only 1 element -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|victor.grousset@biblibre.co | |m | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 70696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70696 Bug 20001: Fix confusion between array and arrayref Review of attachment 70696: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20001&attachment=70696) ----------------------------------------------------------------- ::: Koha/Illrequest.pm @@ +478,4 @@
sub available_backends { my ( $self ) = @_; + my $backends = $self->_config->available_backends;
YIKES! Line 117 of Koha/Illrequest/Config.pm in available_backends returns \@backends, which should be this, and not what it was. Nice fix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- I can't sign off, because I can't figure out how to set up my koha-conf.xml file for inter-library loans. Anyone have documentation or links? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #12 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #11)
I can't sign off, because I can't figure out how to set up my koha-conf.xml file for inter-library loans. Anyone have documentation or links?
Bug 7317 comment #20 was helpful for addressing this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70696|0 |1 is obsolete| | --- Comment #13 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 70700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70700&action=edit Bug 20001: Fix confusion between array and arrayref Illrequest->available_backends always returned only 1 element TEST PLAN --------- See bug 7317 comment #20 for configuring ILL Make sure to restart_all Strangely, ILLIBS didn't exist, but IL did in default install, so use that as the patron code in your koha-conf.xml Make sure to turn on the ILL related system preference. 1) Configure ILL. -- this is the hard part. Hopefully the above will give you enough. 2) open OPAC and log in 3) Click the 'your interlibrary loan request' in the left pane 4) Click the 'Create a new request' button. -- when you hover your mouse over the links for the backends, they will have ARRAY(...) instead of a meaningful name. This is what triggers the error (see comment #7). 5) Run the following commands git checkout -b bug_20001 origin/master git bz apply 20001 reset_all 6) Refresh the OPAC page, and repeat step 4. -- when hovering your mouse over the links for the backends, they will have meaningful values now. 7) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70700|0 |1 is obsolete| | --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 70701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70701&action=edit Bug 20001: Fix confusion between array and arrayref Illrequest->available_backends always returned only 1 element TEST PLAN --------- See bug 7317 comment #20 for configuring ILL Make sure to restart_all Strangely, ILLIBS didn't exist, but IL did in default install, so use that as the patron code in your koha-conf.xml Make sure to turn on the ILL related system preference. 1) Configure ILL. -- this is the hard part. Hopefully the above will give you enough. 2) open OPAC and log in 3) Click the 'your interlibrary loan request' in the left pane 4) Click the 'Create a new request' button. -- when you hover your mouse over the links for the backends, they will have ARRAY(...) instead of a meaningful name. This is what triggers the error (see comment #7). 5) Run the following commands git checkout -b bug_20001 origin/master git bz apply 20001 restart_all 6) Refresh the OPAC page, and repeat step 4. -- when hovering your mouse over the links for the backends, they will have meaningful values now. 7) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The button's functionality is restored with the patch. But the problem of the non-functional exploding Dummy and FreeForm (which should work universally) remains. Actually using the button still leads to: Template process failed: file error - : not found at /home/vagrant/kohaclone/C4/Templates.pm line 122. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70701|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 70737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70737&action=edit Bug 20001: Fix confusion between array and arrayref Illrequest->available_backends always returned only 1 element TEST PLAN --------- See bug 7317 comment #20 for configuring ILL Make sure to restart_all Strangely, ILLIBS didn't exist, but IL did in default install, so use that as the patron code in your koha-conf.xml Make sure to turn on the ILL related system preference. 1) Configure ILL. -- this is the hard part. Hopefully the above will give you enough. 2) open OPAC and log in 3) Click the 'your interlibrary loan request' in the left pane 4) Click the 'Create a new request' button. -- when you hover your mouse over the links for the backends, they will have ARRAY(...) instead of a meaningful name. This is what triggers the error (see comment #7). 5) Run the following commands git checkout -b bug_20001 origin/master git bz apply 20001 restart_all 6) Refresh the OPAC page, and repeat step 4. -- when hovering your mouse over the links for the backends, they will have meaningful values now. 7) run koha qa test tools. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am passing QA on the fix as it's obviously correct, but this bug is not resolved with it yet. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As the create functionality works on the intranet side, I wonder if it's a problem with picking the right templates on OPAC? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- [% PROCESS $whole.opac_template %] doesn't work... but I am not sure why. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #15)
The button's functionality is restored with the patch. But the problem of the non-functional exploding Dummy and FreeForm (which should work universally) remains. Actually using the button still leads to:
Template process failed: file error - : not found at /home/vagrant/kohaclone/C4/Templates.pm line 122.
Dummy works for me -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- https://screenshots.firefox.com/PlajuumMOPG7dPMe/catalogue.kohadev.org And FreeForm as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |nick@bywatersolutions.com --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to Stable for 17.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am using Jonathan's koha-conf.xml configuration now with most extra features turned off. I think the problems I saw might be related to a special combination of features. If I can I will do more testing and open a separate bug if I manage to find the problem case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #25 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Bug 7317 not in 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Jonathan Field <jonathan.field@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.field@ptfs-europe. | |com --- Comment #26 from Jonathan Field <jonathan.field@ptfs-europe.com> --- I managed to reproduce the problem with the Template process failed: file error - : not found at /usr/share/koha/lib/C4/Templates.pm line 122. error. It seems to occur in the OPAC ILL request if you have text in your ILLModuleCopyrightClearance system preference. Once removed, the template loads without a problem. I'll log this as a separate bug as it's unrelated to this one. This is just for information to confirm what Katrin found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx Jonathan! I am sure I had some text in this pref when testing, so this seems the right clue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 --- Comment #28 from Jonathan Field <jonathan.field@ptfs-europe.com> --- I've added a bug 20284 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20536 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20536 [Bug 20536] ILL: authnotrequired not explicitly unset -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20001 Bug 20001 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org