[Bug 19689] New: Koha Offline Circulation Firefox plugin sends entries with wrong branchcode without error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 Bug ID: 19689 Summary: Koha Offline Circulation Firefox plugin sends entries with wrong branchcode without error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The problem that appears most often with the Koha Offline Circulation Plugin is that the libraries enter the wrong branchcode into the configuration. The plugin will send those entries to Koha and they are added to the pending_offline_operations table, but can't be seen in the GUI. It would be nice if the tool showed an error message instead as the only way to fix those entries is with SQL. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matthias.meusburger@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- That would need some work in Koha. Either by having a REST api that would allow the KOCT plugin to check if the branchcode is valid when saving the extension preferences. Or by modifying the *OfflineOperation functions in C4/Circulation.pm to return an error when the branchcode is invalid. By the way, another enhancement would be to return appropriate http error codes (like 401 when the authentication fails) because currently Koha always returns 200. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 --- Comment #2 from Matthias Meusburger <matthias.meusburger@biblibre.com> ---
Either by having a REST api that would allow the KOCT plugin to check if the branchcode is valid when saving the extension preferences.
Or better: by having a REST api that would allow to retrieve branches, so the extension can have them in a dropdown list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Both sound good to me - error codes might be the easier to do for now. We had at least 3 libraries running into this now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 [Bug 16497] Add routes to list libraries -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 Matthias Meusburger <matthias.meusburger@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19752 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19752 [Bug 19752] Improve authentication response in offline_circ/service.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 --- Comment #4 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- The KOCT firefox plugin will add a dropdown list with valid branches and have better configuration errors handling when the related bugs will be available in Koha (16497 and 19752) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- yay! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 Bug 19689 depends on bug 19752, which changed state. Bug 19752 Summary: Improve authentication response in offline_circ/service.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19752 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 --- Comment #6 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Before Bug 16497 is pushed, koct can use this koha api plugin: https://git.biblibre.com/biblibre/koha-plugin-libraries-api to retrieve libraries in a dropdown list, starting from koct 4.0.18 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19689 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is fixed with current versions of Koha and the KOCT Firefox plugin. Once the URL and login are tested, there is now a nice pull down with the available branches from the connected installation. Thx Matts! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org