[Bug 21669] New: TT assignement statements must not be html filtered
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Bug ID: 21669 Summary: TT assignement statements must not be html filtered Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Keywords: rel_18_11_candidate Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org Depends on: 13618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 81184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81184&action=edit Bug 21669: Do not html filter TT assignement statements Why? Because we must filter the variables when we display them. If we escape them on assignement, they will be double escaped: [% XXX = "<span>pouet</span>" | html %] [% XXX | html %] => <span>pouet</span> Also it will bring trouble if we are assigning a structure (see bug 21663 for instance). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- No test plan here, too many changes. - Eyeball the patch - Are the changes make sense? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81184|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 81191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81191&action=edit Bug 21669: Do not html filter TT assignement statements Why? Because we must filter the variables when we display them. If we escape them on assignement, they will be double escaped: [% XXX = "<span>pouet</span>" | html %] [% XXX | html %] => <span>pouet</span> Also it will bring trouble if we are assigning a structure (see bug 21663 for instance). Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|TT assignement statements |TT assignment statements |must not be html filtered |must not be html filtered -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Patch doesn't apply --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt). Repository lacks necessary blobs to fall back on 3-way merge. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Please apply first: Bug 13618: Remove html filter for LAST Bug 21663: Incorrect filter prevents predefined notes from being added to patron acccounts I thought they would have been pushed quickly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply Depends on| |21663 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 [Bug 21663] Incorrect filter prevents predefined notes from being added to patron acccounts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Even with the bugs mentioned I can't get past: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21669: Do not html filter TT assignement statements error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81191|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 81289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81289&action=edit [PASSED QA] Bug 21669: Do not html filter TT assignement statements Why? Because we must filter the variables when we display them. If we escape them on assignement, they will be double escaped: [% XXX = "<span>pouet</span>" | html %] [% XXX | html %] => <span>pouet</span> Also it will bring trouble if we are assigning a structure (see bug 21663 for instance). Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Bug 21669 depends on bug 21663, which changed state. Bug 21663 Summary: Incorrect filter prevents predefined notes from being added to patron acccounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21663 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Caused by bug 13618 not in 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21669 Bug 21669 depends on bug 13618, which changed state. Bug 13618 Summary: Add additional template filter methods and a filter presence test to Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org