http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-06-30 13:03:02 UTC --- Created attachment 4540 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4540 Patch (functionality) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-06-30 13:09:07 UTC --- Z3950 Enhancements include SRU search targets, MARC conversion, additional XSLT processing and some code refactoring. The MARC21 to UNIMARC conversion and additional XSLT processing has actually been created by BibLibre and is incorporated into these two patches. A testplan with 12 steps is included: see http://wiki.koha-community.org/wiki/Z3950_RFC This patch needs a signoff for MARC21 and another one for UNIMARC. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4541|0 |1 is obsolete| | --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-08-11 08:47:35 UTC --- Created attachment 4959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4959 Patch (db revision) -- rebased Rebased. Functional changes from updatedatabase moved to bug 6700. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:58 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff QAContact|koha-bugs@lists.koha-commun |ian.walls@bywatersolutions. |ity.org |com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-21 12:42:16 UTC --- (In reply to comment #8)

Could you perhaps fix and resubmit? I will try to test soon after you did, according to the test plan on the wiki. Resubmitted the dbrev. Hope you can test soon; needs rebasing often..

-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-21 21:52:03 UTC --- So far some notes, but nothing that would prevent a sign-off: 1) Information about SRU configuration should be added to the help file of this page. 2) XSLT and sru field information don't show on administration page, but I think that's ok. Perhaps heading on this page should be changed to Z39.50/SRU server administration to reflect that both options are available now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-12-22 05:40:06 UTC --- Created attachment 6920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6920 [SIGNED-OFF] 6536: Z3950 Enhancements (DB Revision) This patch contains db revision for Z3950 enhancements: SRU search targets, MARC conversion and additional XSLT processing. August 11, 2011: Rebased. Removed changes for different XXX handling (see Bugzilla 6700). December 21, 2011: Rebased. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Followed test plan on the wiki: http://wiki.koha-community.org/wiki/Z3950_RFC 1) Patches apply. 2) Database update was stuck in an endless loop. I removed the comment from the dbversion update in updatedatabase.pl to make it work. I have not added this change to the patch, leaving it for RM. 3) + 12) I added the SRU configuration suggested. Newly added fields save, can be edited and deleted. Note: Information about SRU configuration should be added to the help file of this page. Note: XSLT and sru field information don't show on administration page. Perhaps heading should be changed here to Z39.50/SRU? 4) Successfully performed searches in cataloguing - result list looks ok - marc and isbd preview work - import works 5) Successfully performed searches in acquisitions see above 6) + 8) Searched a UNIMARC target from a MARC21 installation - result list looks ok - marc and isbd preview work - import works, field mapping looks ok Note: isbd view has a little display problem with non filing characters 7) Should be tested by a UNIMARC user 8) Custom XSLT transformation Works great with the example provided. I saved it as MARC21toFunny.xsl into the xslt folder and used a relative url. Result list, previews and imported records show the changes. Note: An option to edit the xsl file online or to upload it here and in other instances would be a nice improvement. 9) Searched 3 targets at once SWB: Z39.50, MARC21 + custom XSLT ABES: Z39.50, UNIMARC Rijksmuseum: SRU Got a mixed result list, result list and previews are all ok. X) Confirmed z39.50 search still works Tried different searches in cataloging and acquisition to confirm there is no regression. All tests passed. I think we need a bit more documentation inside of Koha to make it easier for people to use the new features, but everything I tested works nicely. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-22 14:36:06 UTC --- Created attachment 6924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6924 Follow up to fix MARC21toUNIMARC.xsl BibLibre testing revealed problem in conversion to UNIMARC. Can be resolved by this [simple] follow up on top of other patches. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P3 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Marijana Glavica <mglavica@ffzg.hr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mglavica@ffzg.hr -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Hi Marcel, The good news is I have a patch for the problems we encountered. The xslt transforms with success some notices from the LOC server. The bad news is the precedent patches don't apply anymore. My patch is based on yours patches, I did not get through to rebased them easily :-/ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #22 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #20)

Hi Marcel, The good news is I have a patch for the problems we encountered. The xslt transforms with success some notices from the LOC server. The bad news is the precedent patches don't apply anymore.

My patch is based on yours patches, I did not get through to rebased them easily :-/

Thanks for looking into this again. I still have it on my list. At this time I have a simpler rebased version in production under 3.8 where I removed xslt and marc/unimarc conversion. My new approach for this report would be: 1 move the code to module 2 add the sru targets 3 add the xslt option 4 (rudimentary) marc conversion (if there is still interest for it) Will create some new reports to do this gradually. Your patch has to do with the last two steps. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #23 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- The first step in my previous comment is implemented under report 9105. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #25 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #24)

Hello Marcel, did you plan to do this work soon ? Could we help you to do something ?

Hi Claire: Yes, I will take that up again soon. Your help in signing off would be welcome :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6920|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13462|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Z3950 Enhancements: SRU |Z3950 Enhancements: SRU |targets, MARC conversion, |targets, MARC conversion, |additional XSLT processing |additional XSLT processing | |(umbrella report) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10662 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #27 from David Cook <dcook@prosentient.com.au> --- Hi Marcel! I'm working on a client for OAI-PMH harvesting, so I'm wondering what you're planning in regards to MARC conversion and additional XSLT processing. My plan (and WIP) at the moment is to point to a base url, harvest the records (likely in Dublin core format), store them in a MySQL table, then transform them into MARC and import into Koha. Do you see any problems with this? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #29 from Magnus Enger <magnus@enger.priv.no> --- Could the "MARC Modification Templates" introduced by Byg 8015 be extended to modify records that are imported via Z39.50 to? Docs: http://manual.koha-community.org/3.14/en/catalogtools.html#marcmodtemplates -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11826 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #32 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 26169 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26169&action=edit [TESTPATCH 3.8]8610 Normalize imported Z3950 record Aangepast voor 3.8 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #34 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 26171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26171&action=edit [TESTPATCH 3.8] 6536 3 sru -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #36 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Attached temporarily four 3.8 patches to this report for Paul A. Paul: Please use dbrev in attachment 4541 (obsolete patch on this report). This will add srufields and add_xslt to your z3950servers table. The first attached patch in this series comes from report 8610. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26169|0 |1 is obsolete| | Attachment #26170|0 |1 is obsolete| | Attachment #26171|0 |1 is obsolete| | Attachment #26172|0 |1 is obsolete| | --- Comment #37 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 29754 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29754&action=edit Bug 6536: Dbrev for Z3950 search improvements Adjusts table z3950servers: Drops unused columns icon, description and position. Moves id column to first position. Renames name to servername, and type to servertype. (This is not only more clear but may eliminate some problems too with DBIx.) Changes recordtype from varchar(45) to enumeration with two members. [The upgrade replaces unknown record types with biblio, although it is very unlikely to find such records.] Adds SRU as servertype enumeration member. Removes opensearch, since it is not used/supported. [The upgrade replaces unknown server types with zed (z3950) (in exceptional cases).] Adds new columns: sru_options, sru_fields, add_xslt. Test plan: Run database update via webinstaller. Check your z3950servers table. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #39 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 29756 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29756&action=edit Bug 6536: Add a form for SRU Field mapping This form allows you to enter the match between the standard names of the Z3950 search fields and the field names for a specific SRU server. This patch only adds the form; it will be used in a subsequent patch. Test plan: Not needed, but you can call the form by constructing a URL like: cgi-bin/koha/admin/sru_modmapping.pl?mapping=title=1,author=2 You should see the form with title and author filled. Note that you cannot save the information yet. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #41 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 29779 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29779&action=edit Bug 6536: SRU servers administration This patch makes adjustments in admin/z3950servers in order to insert, edit and delete SRU server records. Test plan: Add, edit, copy and delete SRU server. Check if adding, editing, copying and deleting Z3950 servers still works. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #43 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 29788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29788&action=edit Bug 6536: Include SRU searching in Breeding.pm This patch makes it possible to include SRU servers in Z3950 search. It adjusts the Z3950Search routine in Breeding module. It also replaces SQL code with DBIx statements in Breeding.pm/Z3950Search and the associated scripts z3950search.pl in cataloguing and acqui. Test plan: Verify if a normal Z3950 search still works in cataloging/acqui. Add a SRU target. (You could just use Koha's port 9998.) Define sru_options like sru=get. Use that target in a Z3950 search in cataloging and acqui. (Import.) Test sru_fields translation by comparing search results between various settings for some of the fields. For instance, leave title empty and after that set it to the title field of your SRU target. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #45 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 29791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29791&action=edit [SAMPLE XSLT; DO NOT PUSH] Bug 6536: Two simple test XSLT files You could use Add901.xsl or Set003ABC.xsl in field add_xslt of table z3950servers when testing this report. Set003ABC will change field 003 into ABC. And Add901 adds a tag 901. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 giuseppe.angilella@ct.infn.it changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |giuseppe.angilella@ct.infn. | |it -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29756|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29790|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #48 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29812&action=edit Bug 6536: Dbrev for Z3950 search improvements Adjusts table z3950servers: Drops unused columns icon, description and position. Moves id column to first position. Renames name to servername, and type to servertype. (This is not only more clear but may eliminate some problems too with DBIx.) Changes recordtype from varchar(45) to enumeration with two members. [The upgrade replaces unknown record types with biblio, although it is very unlikely to find such records.] Adds SRU as servertype enumeration member. Removes opensearch, since it is not used/supported. [The upgrade replaces unknown server types with zed (z3950) (in exceptional cases).] Adds new columns: sru_options, sru_fields, add_xslt. Test plan: Run database update via webinstaller. Check your z3950servers table. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #50 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29814 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29814&action=edit Bug 6536: Add a form for SRU Field mapping This form allows you to enter the match between the standard names of the Z3950 search fields and the field names for a specific SRU server. This patch only adds the form; it will be used in a subsequent patch. Test plan: Not needed, but you can call the form by constructing a URL like: cgi-bin/koha/admin/sru_modmapping.pl?mapping=title=1,author=2 You should see the form with title and author filled. Note that you cannot save the information yet. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #52 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29816 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29816&action=edit Bug 6536: Adjustments for servername and servertype Replaces name by servername, type by servertype for running Z3950 search. Limit search scripts to zed (z3950) servers until sru is supported. Test plan: Perform a Z3950 search in Cataloguing and Acquisition. Verify that it still works as it did. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #54 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29818 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29818&action=edit Bug 6536: Add XSLT transformation on Z3950 search results Use the stylesheets listed in field add_xslt of z3950servers to transform search results of Z3950/SRU search. Additionally, the template has been changed to make more error messages (or warnings) visible when displaying results. Until now, error message were shown in the results table and when connection errors occurred, no results were displayed at all. Test plan: Create some stylesheets (or see the sample patch on bug 6536). Add these stylesheets to some Z3950/SRU servers. Do Z3950 search and verify the transformations. Do a search with 2 targets; make one target fail (by manipulating its server data). Do you see the connection error and the results for the other target? Generate a XSLT error by modifying one stylesheet. Check search results. You should see warnings. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 11109 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #58 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30190&action=edit Bug 6536: Update DBIx schema of z3950servers for testing This patch adjusts the DBIx schema file for z3950servers table. This can be used for testing this set of patches. When the report is pushed, the RM should update the DBIx schema. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #60 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30192&action=edit Bug 6536: Adjustments for servername and servertype Replaces name by servername, type by servertype for running Z3950 search. Limit search scripts to zed (z3950) servers until sru is supported. Test plan: Perform a Z3950 search in Cataloguing and Acquisition. Verify that it still works as it did. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #62 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30194&action=edit Bug 6536: Add XSLT transformation on Z3950 search results Use the stylesheets listed in field add_xslt of z3950servers to transform search results of Z3950/SRU search. Additionally, the template has been changed to make more error messages (or warnings) visible when displaying results. Until now, error message were shown in the results table and when connection errors occurred, no results were displayed at all. Test plan: Create some stylesheets (or see the sample patch on bug 6536). Add these stylesheets to some Z3950/SRU servers. Do Z3950 search and verify the transformations. Do a search with 2 targets; make one target fail (by manipulating its server data). Do you see the connection error and the results for the other target? Generate a XSLT error by modifying one stylesheet. Check search results. You should see warnings. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #63 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased some patches in this series. The order has been slightly adjusted. The first two patches (in the current order) only add new files and are on top now. This should not do any harm imho.. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29814|0 |1 is obsolete| | Attachment #29819|0 |1 is obsolete| | Attachment #30189|0 |1 is obsolete| | Attachment #30190|0 |1 is obsolete| | Attachment #30191|0 |1 is obsolete| | Attachment #30192|0 |1 is obsolete| | Attachment #30193|0 |1 is obsolete| | Attachment #30194|0 |1 is obsolete| | --- Comment #65 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30900&action=edit Bug 6536: Add a form for SRU Field mapping This form allows you to enter the match between the standard names of the Z3950 search fields and the field names for a specific SRU server. This patch only adds the form; it will be used in a subsequent patch. Test plan: Not needed, but you can call the form by constructing a URL like: cgi-bin/koha/admin/sru_modmapping.pl?mapping=title=1,author=2 You should see the form with title and author filled. Note that you cannot save the information yet. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #67 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30902&action=edit Bug 6536: Dbrev for Z3950 search improvements Adjusts table z3950servers: Drops unused columns icon, description and position. Moves id column to first position. Renames name to servername, and type to servertype. (This is not only more clear but may eliminate some problems too with DBIx.) Changes recordtype from varchar(45) to enumeration with two members. [The upgrade replaces unknown record types with biblio, although it is very unlikely to find such records.] Adds SRU as servertype enumeration member. Removes opensearch, since it is not used/supported. [The upgrade replaces unknown server types with zed (z3950) (in exceptional cases).] Adds new columns: sru_options, sru_fields, add_xslt. Test plan: Run database update via webinstaller. Check your z3950servers table. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #69 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30904&action=edit Bug 6536: SRU servers administration This patch makes adjustments in admin/z3950servers in order to insert, edit and delete SRU server records. Test plan: Add, edit, copy and delete SRU server. Check if adding, editing, copying and deleting Z3950 servers still works. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #71 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30906 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30906&action=edit Bug 6536: Include SRU searching in Breeding.pm This patch makes it possible to include SRU servers in Z3950 search. It adjusts the Z3950Search routine in Breeding module. It also replaces SQL code with DBIx statements in Breeding.pm/Z3950Search and the associated scripts z3950search.pl in cataloguing and acqui. Test plan: Verify if a normal Z3950 search still works in cataloging/acqui. Add a SRU target. (You could just use Koha's port 9998.) Define sru_options like sru=get. Use that target in a Z3950 search in cataloging and acqui. (Import.) Test sru_fields translation by comparing search results between various settings for some of the fields. For instance, leave title empty and after that set it to the title field of your SRU target. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30901|Bug 6536: Two simple test |[TESTING_ONLY] Bug 6536: description|XSLT files |Two simple test XSLT files -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #73 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Rebased it again. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #75 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also.. any chance of a documentation patch to go along with the updated functionality? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30900|0 |1 is obsolete| | --- Comment #77 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30929&action=edit [PASSED QA] Bug 6536: Add a form for SRU Field mapping This form allows you to enter the match between the standard names of the Z3950 search fields and the field names for a specific SRU server. This patch only adds the form; it will be used in a subsequent patch. Test plan: Not needed, but you can call the form by constructing a URL like: cgi-bin/koha/admin/sru_modmapping.pl?mapping=title=1,author=2 You should see the form with title and author filled. Note that you cannot save the information yet. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30902|0 |1 is obsolete| | --- Comment #79 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30931 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30931&action=edit [PASSED QA] Bug 6536: Dbrev for Z3950 search improvements Adjusts table z3950servers: Drops unused columns icon, description and position. Moves id column to first position. Renames name to servername, and type to servertype. (This is not only more clear but may eliminate some problems too with DBIx.) Changes recordtype from varchar(45) to enumeration with two members. [The upgrade replaces unknown record types with biblio, although it is very unlikely to find such records.] Adds SRU as servertype enumeration member. Removes opensearch, since it is not used/supported. [The upgrade replaces unknown server types with zed (z3950) (in exceptional cases).] Adds new columns: sru_options, sru_fields, add_xslt. Test plan: Run database update via webinstaller. Check your z3950servers table. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30904|0 |1 is obsolete| | --- Comment #81 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30933&action=edit [PASSED QA] Bug 6536: SRU servers administration This patch makes adjustments in admin/z3950servers in order to insert, edit and delete SRU server records. Test plan: Add, edit, copy and delete SRU server. Check if adding, editing, copying and deleting Z3950 servers still works. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30906|0 |1 is obsolete| | --- Comment #83 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 30935 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30935&action=edit [PASSED QA] Bug 6536: Include SRU searching in Breeding.pm This patch makes it possible to include SRU servers in Z3950 search. It adjusts the Z3950Search routine in Breeding module. It also replaces SQL code with DBIx statements in Breeding.pm/Z3950Search and the associated scripts z3950search.pl in cataloguing and acqui. Test plan: Verify if a normal Z3950 search still works in cataloging/acqui. Add a SRU target. (You could just use Koha's port 9998.) Define sru_options like sru=get. Use that target in a Z3950 search in cataloging and acqui. (Import.) Test sru_fields translation by comparing search results between various settings for some of the fields. For instance, leave title empty and after that set it to the title field of your SRU target. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #85 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Passing QA Nice work marcel, this adds a useful and usable enhancement. As commented above, I see a number of further follow-ups, but would be happy to see them as separate follow-up bugs once this piece has made it's way in and a few other areas of code have settled enough for the follow-ups to be based upon them. The main one I would like to see is a clear documentation patch to show exactly how one should configure all this stuff as is. It currently lies firmly in the system admin field for the xslt transformations stuff.. but even the SRU pieces need 'extra bits' that a normal library admin may not fully understand without a little more guidance. I can't find any regressions and the code all checks out through the qa scripts. SRU wise.. I tested mostly against the LOC SRU gateway.. but I also did some quick tests against a koha instance and a few other places. To note, if the gateway only outputs dublin core, then this it will not work with koha.. another future enhancement maybe. To test against LOC: Host: z3950.loc.gov Port: 7090 Database: voyager -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30936|0 |1 is obsolete| | --- Comment #87 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31046 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31046&action=edit Bug 6536: Add XSLT transformation on Z3950 search results Use the stylesheets listed in field add_xslt of z3950servers to transform search results of Z3950/SRU search. Additionally, the template has been changed to make more error messages (or warnings) visible when displaying results. Until now, error message were shown in the results table and when connection errors occurred, no results were displayed at all. Test plan: Create some stylesheets (or see the sample patch on bug 6536). Add these stylesheets to some Z3950/SRU servers. Do Z3950 search and verify the transformations. Do a search with 2 targets; make one target fail (by manipulating its server data). Do you see the connection error and the results for the other target? Generate a XSLT error by modifying one stylesheet. Check search results. You should see warnings. Signed-off-by: Giuseppe Angilella <giuseppe.angilella@ct.infn.it> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |1561 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #90 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Martin: Thanks for QAing. Tomas: I will first put a note on this report how I will implement some of the documentation issues Martin mentioned before. New reports will deal with functionality changes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #91 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31137 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31137&action=edit Bug 6536: QA Follow-up for string changes referring to Z39.50 Z39.50 search now includes SRU targets. This patch only touches strings referring to it. No changes in behavior. It replaces Z39.50 with Z39.50/SRU or external. Deletes obsolete template z3950/searchresult.tt: not in use for some time. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12823 -- You are receiving this mail because: You are watching all bug changes.

3. Hint to define the SRU search field mappings I extended the solution for point 2 to include this point. So see also bug

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #94 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to M. de Rooy from comment #92) 12823. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #95 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to M. de Rooy from comment #92)

4. Documentation patch The online Help is updated via bug 12828. Can be handled separately.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #97 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31194&action=edit Bug 6536: QA Follow-up for removing warnings from QA tools Resolved: [1] FAIL C4/Breeding.pm FAIL critic [2] FAIL koha-tmpl/intranet-tmpl/prog/en/modules/help/admin/z3950servers.tt FAIL forbidden patterns forbidden pattern: tab char (line 15) forbidden pattern: tab char (line 21) forbidden pattern: tab char (line 16) [3] FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/z3950servers.tt FAIL forbidden patterns forbidden pattern: trailing space char (line 62) forbidden pattern: trailing space char (line 54) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> No warnings anymore. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31194|0 |1 is obsolete| | --- Comment #99 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Comment on attachment 31194 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31194 Bug 6536: QA Follow-up for removing warnings from QA tools Sorry, this implies the separate follow-up reports too. Will revise. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #101 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Marcel, last test on the first series, fails randomly on Perl 5.18: not ok 12 - Third query makes no difference # Failed test 'Third query makes no difference' # at t/db_dependent/Breeding.t line 104. # got: '' # expected: '1' # Looks like you failed 1 test of 12. not ok 1 - _build_query -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #103 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #101)

Marcel, last test on the first series, fails randomly on Perl 5.18:

Good catch, Tomas. It did not fail with me under Perl 5.14. I will sign off your suggested change. Thanks. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #104 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31227&action=edit Bug 6536: QA Follow-up for fixing a unit test under Perl 5.18 The last test on the first series, fails randomly on Perl 5.18: not ok 12 - Third query makes no difference # Failed test 'Third query makes no difference' # at t/db_dependent/Breeding.t line 104. # got: '' # expected: '1' # Looks like you failed 1 test of 12. not ok 1 - _build_query This change makes tests pass. Please consider if this needs to be fixed (i.e. sort order matters) or the test needs to be rewritten. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> I agree with adding the sort. (The need for doing this in Perl 5.18 is another topic.) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31137|[PASSED_QA] Bug 6536: QA |Bug 6536: QA Follow-up for description|Follow-up for string |string changes referring to |changes referring to Z39.50 |Z39.50 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #105 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Must still add a patch for the two renamed cols in sql files of new install. Development never stops ;) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 --- Comment #107 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31248 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31248&action=edit Bug 6536: Follow-up: Updating installer sql files for z3950servers (Part 2) This patch renames name to servername and type to servertype. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Tested all sql files by script. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #109 from Tomás Cohen Arazi <tomascohen@gmail.com> --- New feature pushed to master! Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12864 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org --- Comment #111 from Dobrica Pavlinusic <dpavlin@rot13.org> --- This bug introduced regression fixed in Bug 12898 - Z39.50 title search doesn't work with multiple words -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37264|sample xslt |sample MARC21 to UNIMARC description| |xslt -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6536 Manos PETRIDIS <egpetridis@yahoo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |egpetridis@yahoo.com --- Comment #113 from Manos PETRIDIS <egpetridis@yahoo.com> --- Is there any functional UNIMARC to MARC21 MARC conversion xslt available? In other words, how may one search UNIMARC z39.50 targets in order to populate a MARC21 library? -- You are receiving this mail because: You are watching all bug changes.