[Bug 17466] New: Show number of outstanding issues when checking in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Bug ID: 17466 Summary: Show number of outstanding issues when checking in Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 --- Comment #1 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 56654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56654&action=edit Bug 17466: Show number of outstanding issues when checking in Test plan: 1) Apply patch 2) Checkout more then one item to a borrower 3) Check one of that items 4) Note, that on in returns table there is a button with number of outstanding issues in patron column. The button should take you to checking out page 5) When the outstanding issues count is 0, there is no button -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |josef.moravec@gmail.com |ity.org | CC| |black23@gmail.com, | |rbit@rbit.cz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56654|0 |1 is obsolete| | --- Comment #2 from Radek Šiman (R-Bit Technology, s.r.o.) <rbit@rbit.cz> --- Created attachment 57806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57806&action=edit Bug 17466: Show number of outstanding issues when checking in Test plan: 1) Apply patch 2) Checkout more then one item to a borrower 3) Check one of that items 4) Note, that on in returns table there is a button with number of outstanding issues in patron column. The button should take you to checking out page 5) When the outstanding issues count is 0, there is no button Signed-off-by: Radek Šiman <rbit@rbit.cz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |oleonard@myacpl.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I am not sure a button is the right element to use here. Maybe a simple link is enough. CCing Owen to get his opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I agree that a button isn't appropriate for what is acting as a link. I would suggest using a plain link, or using <a class="btn btn-mini btn-link"> which I think works well. Another comment: In the default translation we don't use the term "Issues" in this context. "Checkouts" is correct. https://wiki.koha-community.org/wiki/Terminology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 58191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58191&action=edit Bug 17466: Followup, change button to link and fix terminology -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Owen Leonard from comment #4)
I agree that a button isn't appropriate for what is acting as a link. I would suggest using a plain link, or using <a class="btn btn-mini btn-link"> which I think works well.
Another comment: In the default translation we don't use the term "Issues" in this context. "Checkouts" is correct.
Thanks Owen, I fixed it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57806|0 |1 is obsolete| | Attachment #58191|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 58541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58541&action=edit Bug 17466: Show number of outstanding issues when checking in Test plan: 1) Apply patch 2) Checkout more then one item to a borrower 3) Check one of that items 4) Note, that on in returns table there is a button with number of outstanding issues in patron column. The button should take you to checking out page 5) When the outstanding issues count is 0, there is no button Signed-off-by: Radek Šiman <rbit@rbit.cz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 58542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58542&action=edit Bug 17466: Followup, change button to link and fix terminology Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 58543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58543&action=edit Bug 17466 [QA Followup] - Give the link some style Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Josef! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |FIXED --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17919 [Bug 17919] circ/returns.pl caught in Object Name crossfire -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Could not compile /home/vagrant/kohaclone/circ/returns.pl: Can't locate Koha/Issues.pm See bug 17919. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17466 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20003 [Bug 20003] Result summary of remaining checkouts items not displaying. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org