[Bug 16275] New: Prevent patron creation if the email already filled in borrowers.email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Bug ID: 16275 Summary: Prevent patron creation if the email already filled in borrowers.email Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nicolas.legrand@bulac.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Some of our patrons are not sure they succeed their self registration and self register multiple times. We would like to prevent this by blocking the selfregistration if the field borrowers.email is already filled by the same email address. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50612&action=edit Bug 16275: Add the new pref PatronSelfRegistrationEmailMustBeUnique Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50613&action=edit Bug 16275: Do not allow a self registration with an existing email address To avoid multiple registrations, it would be good to check the unicity of the primary email address. This patchset adds a new pref PatronSelfRegistrationEmailMustBeUnique. If on, a patron will get "This email address already exists in our database" if he try to register with an existing email address. Test plan: 1/ Register a new patron with an email address 2/ Make an other registration using the same email address => With the pref PatronSelfRegistrationEmailMustBeUnique on, you won't be allowed => With the pref off, no change should be noticed. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50612|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51064&action=edit [SIGNED-OFF] Bug 16275: Add the new pref PatronSelfRegistrationEmailMustBeUnique Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50613|0 |1 is obsolete| | --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 51065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51065&action=edit [SIGNED-OFF] Bug 16275: Do not allow a self registration with an existing email address To avoid multiple registrations, it would be good to check the unicity of the primary email address. This patchset adds a new pref PatronSelfRegistrationEmailMustBeUnique. If on, a patron will get "This email address already exists in our database" if he try to register with an existing email address. Test plan: 1/ Register a new patron with an email address 2/ Make an other registration using the same email address => With the pref PatronSelfRegistrationEmailMustBeUnique on, you won't be allowed => With the pref off, no change should be noticed. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 --- Comment #5 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 51181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51181&action=edit Bug 16275: Add the new pref PatronSelfRegistrationEmailMustBeUnique Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 --- Comment #6 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 51182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51182&action=edit Bug 16275: Do not allow a self registration with an existing email address To avoid multiple registrations, it would be good to check the unicity of the primary email address. This patchset adds a new pref PatronSelfRegistrationEmailMustBeUnique. If on, a patron will get "This email address already exists in our database" if he try to register with an existing email address. Test plan: 1/ Register a new patron with an email address 2/ Make an other registration using the same email address => With the pref PatronSelfRegistrationEmailMustBeUnique on, you won't be allowed => With the pref off, no change should be noticed. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51064|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51065|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16985 CC| |katrin.fischer@bsz-bw.de --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- In general this seems to work nicely without enforcing email verification (PatronSelfRegistrationVerifyByEmail). I ran into problems testing with email verification, because of bug 16985. It seems you can register as many patrons as you want with the same e-mail as long as they are not confirmed. I wanted to test to the second patron to use the confirmation link, but can't right now. Jonathan, can you describe what should happen? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 [Bug 16985] Self registration verification e-mail is broken - no token at the end of the URL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Bug 16275 depends on bug 16985, which changed state. Bug 16985 Summary: Self registration verification e-mail is broken - no token at the end of the URL https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #7)
It seems you can register as many patrons as you want with the same e-mail as long as they are not confirmed. I wanted to test to the second patron to use the confirmation link, but can't right now. Jonathan, can you describe what should happen?
Yes, it is the expected behavior. The test is only done on registered patrons. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Prevent patron creation if |Prevent patron self |the email already filled in |registration if the email |borrowers.email |already filled in | |borrowers.email -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51181|0 |1 is obsolete| | Attachment #51182|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53862&action=edit [PASSED QA] Bug 16275: Add the new pref PatronSelfRegistrationEmailMustBeUnique Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No errors Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 53863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53863&action=edit [PASSED QA] Bug 16275: Do not allow a self registration with an existing email address To avoid multiple registrations, it would be good to check the unicity of the primary email address. This patchset adds a new pref PatronSelfRegistrationEmailMustBeUnique. If on, a patron will get "This email address already exists in our database" if he try to register with an existing email address. Test plan: 1/ Register a new patron with an email address 2/ Make an other registration using the same email address => With the pref PatronSelfRegistrationEmailMustBeUnique on, you won't be allowed => With the pref off, no change should be noticed. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors. Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|16985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985 [Bug 16985] Self registration verification e-mail is broken - no token at the end of the URL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12566 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #11 from Christopher Brannon <cbrannon@cdalibrary.org> --- I am grateful that this is a preference and not a behavior change. We have many family members that use the same e-mail address for more than one account, and this would make it impossible for them to register more than one family member. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It's totally optional - I tested with the option being off as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19366 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19366 [Bug 19366] PatronSelfRegistrationEmailMustBeUnique pref makes it impossible to submit updates via OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16275 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22458 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 [Bug 22458] PatronSelfRegistrationEmailMustBeUnique disallows self modification requests if multiple accounts share an email address -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org