[Bug 12728] New: Add StatisticsFields to sysprefs.sql
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 Bug ID: 12728 Summary: Add StatisticsFields to sysprefs.sql Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org Bug 7955: [Statistics tab for Patron checkouts] introduced pref StatisticsFields but did not add it to the sql install file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 30578 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30578&action=edit Bug 12728: Add StatisticsFields to sysprefs.sql Bug 7955: [Statistics tab for Patron checkouts] introduced the pref StatisticsFields but did not add it to the sql install file. Test plan: Run webinstaller or mysql ... < sysprefs.sql Verify that the new pref is in your systempreferences table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30578|0 |1 is obsolete| | --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 30588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30588&action=edit [SIGNED-OFF] Bug 12728: Add StatisticsFields to sysprefs.sql Bug 7955: [Statistics tab for Patron checkouts] introduced the pref StatisticsFields but did not add it to the sql install file. Test plan: Run webinstaller or mysql ... < sysprefs.sql Verify that the new pref is in your systempreferences table. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Run webinstall, new syspref loaded. No koha-qa errors. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30588|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30865&action=edit [PASSED QA] Bug 12728: Add StatisticsFields to sysprefs.sql Bug 7955: [Statistics tab for Patron checkouts] introduced the pref StatisticsFields but did not add it to the sql install file. Test plan: Run webinstaller or mysql ... < sysprefs.sql Verify that the new pref is in your systempreferences table. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Run webinstall, new syspref loaded. No koha-qa errors. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patch is ok, but should we also add a updatedatabase entry adding it to the installations it's missing from now? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 31044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31044&action=edit Bug 12728: [QA Follow-up] Add StatisticsFields to sysprefs.sql This patch adds a dbrev. If people installed Koha after the initial dbrev (3.09.00.015), an install with sysprefs.sql did not add the pref. So they still could not have it. Test plan: If you have the pref, running an database update should not do anything. If you do not have the pref (delete it via mysql), it should be added. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 --- Comment #6 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #4)
The patch is ok, but should we also add a updatedatabase entry adding it to the installations it's missing from now?
Added it for completeness. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marcel! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12728 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org