[Bug 4045] New: No check for maximum number of allowed holds.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 Summary: No check for maximum number of allowed holds. Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Hold requests AssignedTo: henridamien@koha-fr.org ReportedBy: oleonard@myacpl.org Estimated Hours: 0.0 Change sponsored?: --- At some point updatedatabase removed the "maxreserves" system preference: $dbh->do('DELETE FROM systempreferences WHERE variable = "maxreserves";'); But the opac and staff client still checks for that preference when placing holds. From request.pl: if ( $number_reserves > C4::Context->preference('maxreserves') ) { $warnings = 1; $maxreserves = 1; } chris fixed this in the OPAC (Bug by allowing holds if maxreserves is not set, which we could apply to the staff client: if ( C4::Context->preference('maxreserves') && $number_reserves > C4::Context->preference('maxreserves') ) { $warnings = 1; $maxreserves = 1; } ...but that is just bypasses the problem: There is no check of the "Holds Allowed" value specified in the issuingrules table. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 hdlaurent <henridamien@koha-fr.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 Jane Wagner <jwagner@ptfs.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jwagner@ptfs.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.edu AssignedTo|henridamien@koha-fr.org |cnighswonger@foundations.edu Status|ASSIGNED |NEW --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-02-01 17:14:34 --- Reassigning to myself. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 --- Comment #2 from Chris Nighswonger <cnighswonger@foundations.edu> 2010-02-10 17:26:20 --- Work from Biblibre addresses this, but will not make it into 3.2. This work should be included in 3.4. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2010-02-10 18:01:40 --- If the maxreserves preference stays deleted and the limits defined in issuing rules are ignored, 3.2 will ship with no way for librarians to limit the number of holds a patron can place. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 --- Comment #4 from Jane Wagner <jwagner@ptfs.com> 2010-02-10 18:24:04 --- We have some development (not yet submitted) that requires maxreserves, so if it's deleted we'd have to add it back in. Apart from that, I really believe libraries need the option to limit number of holds. I'd strongly suggest this syspref be retained. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 --- Comment #5 from hdlaurent <henridamien@koha-fr.org> 2010-02-11 00:30:31 --- In a development we did, the maxreserves (and delay, and holdspolicy) is included in issuingrules. So that max reserves as such would not be required any longer. Maybe we could share our devs and see if we can reconcile them. ours is on a public branch on git.biblibre.com -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 --- Comment #6 from Jane Wagner <jwagner@ptfs.com> 2010-02-11 13:06:05 --- We'll take a look at your github and also at latest head -- we're going to have to reconcile our code to all the updates since we froze our development level. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 --- Comment #7 from Jane Wagner <jwagner@ptfs.com> 2010-05-12 13:22:49 --- Updating, see Bug 3507 -- I think that uses maxreserves as a backup setting. It could probably be reconciled. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|cnighswonger@foundations.edu|gmcharlt@gmail.com Status|ASSIGNED |NEW --- Comment #8 from Owen Leonard <oleonard@myacpl.org> 2010-05-12 14:11:17 --- There is still one check of C4::Context->preference("maxreserves") that I can find, in opac-reserve.pl (excluding one in Utility.pm which doesn't seem to be used) Hold limits work inconsistently in the OPAC: -- If the patron has not yet exceeded the maximum allowed number of holds, it is possible to place an unlimited number of multiple holds in one transaction. Koha seems to say, "Patron has not reached the limit of allowable holds, so allow this holds transaction to take place." The system should instead allow holds only up to the number of allowable holds. This would require the interface to know the number of available holds and keep track of how many of multiple holds were selected. -- If the patron has reached or exceeded the maximum allowed number of holds, the OPAC will *not* block the transaction with the built in warning, "Sorry, you cannot place more than <!-- TMPL_VAR NAME="too_many_reserves" --> holds" because that warning only works with the "maxreserves" system preference. Instead the user will be shown the title(s) he has chosen, but the title(s) will be shown with the message "This title cannot be requested." The wording of this message implies that there is a problem with that particular title, not a problem with the number of holds the user has. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4045 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> 2010-05-12 14:21:59 --- Testing holds limits in the staff client: -- When placing a single hold for a patron who has exceeded their maximum allowed number of holds, Koha warns that the users has too many holds, but does not block the transaction. -- When placing multiple holds for a patron who has exceeded their maximum allowed number of holds, Koha reports "Cannot place hold on some items," but does not block the transaction. -- Configure bugmail: http://bugs.koha.org/cgi-bin/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠kohaorg.ec2.liblime.com