[Bug 29780] New: Add Koha::Old::Holds->anonymize
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Bug ID: 29780 Summary: Add Koha::Old::Holds->anonymize Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Add high-level methods to anonymize holds history as needed by bug 29526. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29526 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128964&action=edit Bug 29780: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128965&action=edit Bug 29780: Add Koha::Old::Holds->anonymize This patch adds a handy method for anonymizing a Koha::Old::Holds resultset. It is planned to be used on bug 29526. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128964|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128966&action=edit Bug 29780: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Just added some more tests, for the empty restultset case, which returns the weird '0E0' value instead of plain zero [1], and wanted to highlight it, as I stumbled upon it on bug 29526. [1] https://stackoverflow.com/questions/13358793/why-does-dbis-do-method-return-... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128965|0 |1 is obsolete| | Attachment #128966|0 |1 is obsolete| | --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128978&action=edit Bug 29780: Add Koha::Old::Holds->anonymize This patch adds a handy method for anonymizing a Koha::Old::Holds resultset. It is planned to be used on bug 29526. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128979&action=edit Bug 29780: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|29526 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 [Bug 29526] Add 'Immediately delete holds history' button to patron privacy tab in opac -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128978|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130252&action=edit Bug 29780: Add Koha::Old::Holds->anonymize This patch adds a handy method for anonymizing a Koha::Old::Holds resultset. It is planned to be used on bug 29526. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Old/Holds.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128979|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130253&action=edit Bug 29780: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- A simple and clear patch that works as expected and contains thorough unit tests. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org