https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 59429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59429&action=edit Bug 17962: Add Koha::Tmp::Order[s] These packages should not be used outside the TT syntax scope. A rewrite of Koha::Acquisition::Order[s] should be considered instead. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17961 [Bug 17961] TT syntax for notices - Prove we have an equivalent for our historical custom syntax -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #59428|0 |1 is obsolete| | Attachment #59429|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 59525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59525&action=edit [SIGNED-OFF] Bug 17962: TT syntax for notices - Prove that ACQ_NOTIF_ON_RECEIV is compatible To make ACQ_NOTIF_ON_RECEIV TT compatible, we need to expose data from the aqorders table. We already have a package for it in the Koha namespace but it is based on Koha::Object[s]. The other path creates dummy Koha::Tmp::Order[s] packages to make it usable. Of course we should use a valid Koha::Acquisition::Order[s] based on Koha::Object, but it's outside the scope of this bug report. This notice template is quite simple, and it's a good one to start.

From C4::Acq::NotifyOrderUsers, GetPreparedLetter is called with 4 elements: the library, the patron to notify, the biblio and the order information. Note that prior to this patch aqorders was filled from GetOrder, which retrieved a lot of information from the acquisition table (aqbasket, aqbookseller). The idea with the TT syntax is to access the data from where it really exists. So if a user wants to display the basket name, [% order.basket.basketname %] should be used instead. Note that this will not work at the moment, the basket method is not defined in the order package.

However the basic template should work as before. The test added to TemplateToolkit proves that. Test plan: Use the default ACQ_NOTIF_ON_RECEIV to notify a patron that an order has been received. That generated template should be exactly the same as prior to this patch. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17962 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This won't get ported back to 16.11.x as it is an enhancement. -- You are receiving this mail because: You are watching all bug changes.