[Bug 17481] New: Cas Logout: bug 11048 has been incorrectly merged
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Bug ID: 17481 Summary: Cas Logout: bug 11048 has been incorrectly merged Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt@gmail.com Reporter: matthias.meusburger@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org Bug 11048 (Fix logout redirection for CAS authentication) has been incorrectly merged: In Bugzilla, https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23865 : - print $query->redirect( $cas->logout_url($uri)); + print $query->redirect( $cas->logout_url(url => $uri)); In master, git show c251f752 : print $query->redirect( $cas->logout_url($uri)); + print $query->redirect( $cas->logout_url(url => $uri)); => CAS redirection is still broken in master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 --- Comment #1 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Created attachment 56723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56723&action=edit Bug 17481: Fix incorrect merge of bug 11048 (logout redirection for CAS authentication) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|NEW |Needs Signoff --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be 'Needs Signoff' or something else to get RMs attention? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |matthias.meusburger@biblibr | |e.com CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |major --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looking at the changes, it sounds trivial that the patches waited for 6 months and that it conflicts. Redirect after a redirect does not make sense. I would be keen to sent it to PQA directly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Go for it! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd happily PQA this directly too.. that's three of us n agreement.. I'm gonna just go ahead and set it ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 57248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57248&action=edit [PASSED QA] Bug 17481: Fix incorrect merge of bug 11048 (logout redirection for CAS authentication) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Matthias! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Pushed to 3.22.x, will be in 3.22.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.06 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18046 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18046 [Bug 18046] Problem with redirect on logout with CAS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Matthias, Has this patch been tested? It seems that it still does not work, see bug 18046. This story is becoming to be very too long... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 --- Comment #11 from Matthias Meusburger <matthias.meusburger@biblibre.com> --- Hi, I did test this patch back then. It worked perfectly. Something has changed since, obviously. Currently waiting for a CAS server to test this against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17481 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I was wondering how to solve this. Coudl one solution be to send the user back to OpacBaseUrl? It seems to make sense to send them back to the start page on logout. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org