[Bug 15072] New: Breadcrumbs and titles inconsistent in Label creator
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Bug ID: 15072 Summary: Breadcrumbs and titles inconsistent in Label creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14667 Assignee|cnighswonger@foundations.ed |tomascohen@gmail.com |u | CC| |katrin.fischer@bsz-bw.de, | |liz@catalyst.net.nz --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- After the UX/UI patches got pushed, the only missing piece was making the breadcrumbs more consistent. The same applies to the page title. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14667 [Bug 14667] Label creator UI/UX revamp -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44097&action=edit Bug 15072: Breadcrumbs and titles inconsistent in Label creator This patch makes the page title and breadcrumbs more consistent. It does so by removing some text (Manage...) and using Edit (id) and Create on building both the breadcrumbs and titles. To test: - Traverse all the Label creator options => FAIL: the texts are not consistent and don't match what we use in the patron card creator. - Apply the patch => SUCCESS: Terminology is consistent, titles and breadcrumbs show the same information - Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44098&action=edit Bug 15072: (followup) We use 'New' instead of 'Create' on the UI This patch makes the UI show 'New' instead of 'Create' so it matches the buttons, and the common practice on the UI. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 44099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44099&action=edit Bug 15072: (followup) Use 'New' on Patron card creator too This patch makes the change on the patron cards creator tool too. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen@gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #5 from Marc Véron <veron@veron.ch> --- Created attachment 44120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44120&action=edit Bug 14722: CSV is only available for biblio records Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #44120|0 |1 is obsolete| | --- Comment #6 from Marc Véron <veron@veron.ch> --- Comment on attachment 44120 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44120 Bug 14722: CSV is only available for biblio records Sorry, i messed something whil trying to attach multiple patches. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44097|0 |1 is obsolete| | --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44170&action=edit [SIGNED-OFF] Bug 15072: Breadcrumbs and titles inconsistent in Label creator This patch makes the page title and breadcrumbs more consistent. It does so by removing some text (Manage...) and using Edit (id) and Create on building both the breadcrumbs and titles. To test: - Traverse all the Label creator options => FAIL: the texts are not consistent and don't match what we use in the patron card creator. - Apply the patch => SUCCESS: Terminology is consistent, titles and breadcrumbs show the same information - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44098|0 |1 is obsolete| | --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44171&action=edit [SIGNED-OFF] Bug 15072: (followup) We use 'New' instead of 'Create' on the UI This patch makes the UI show 'New' instead of 'Create' so it matches the buttons, and the common practice on the UI. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44099|0 |1 is obsolete| | --- Comment #9 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44172 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44172&action=edit [SIGNED-OFF] Bug 15072: (followup) Use 'New' on Patron card creator too This patch makes the change on the patron cards creator tool too. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All patches without errors. More consistent view. A few spaces and a little fix in followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44173 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44173&action=edit Bug 15072: (followup) fix spaces and consistency This patch add a few spaces when required and adds layout_id on title and breadcrumbs (for patroncards) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44170|0 |1 is obsolete| | Attachment #44171|0 |1 is obsolete| | Attachment #44172|0 |1 is obsolete| | Attachment #44173|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44188 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44188&action=edit Bug 15072: Breadcrumbs and titles inconsistent in Label creator This patch makes the page title and breadcrumbs more consistent. It does so by removing some text (Manage...) and using Edit (id) and Create on building both the breadcrumbs and titles. To test: - Traverse all the Label creator options => FAIL: the texts are not consistent and don't match what we use in the patron card creator. - Apply the patch => SUCCESS: Terminology is consistent, titles and breadcrumbs show the same information - Sign off :-D Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44189 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44189&action=edit Bug 15072: (followup) We use 'New' instead of 'Create' on the UI This patch makes the UI show 'New' instead of 'Create' so it matches the buttons, and the common practice on the UI. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44190 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44190&action=edit Bug 15072: (followup) Use 'New' on Patron card creator too This patch makes the change on the patron cards creator tool too. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> All patches without errors. More consistent view. A few spaces and a little fix in followup Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 --- Comment #14 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 44191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44191&action=edit Bug 15072: (followup) fix spaces and consistency This patch add a few spaces when required and adds layout_id on title and breadcrumbs (for patroncards) Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15072 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks for the followup, Bernardo! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org