https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com Severity|enhancement |minor Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Course reserves instructors |Opac: Course reserves |should be in form "Surname, |instructors should be in |Firstname" for sorting |form "Surname, Firstname" |purposes |for sorting purposes CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- "firstname, surname" is the form we usually use to display a patron name. I am not sure about this change, ccing Owen and Katrin to get some feedbacks. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 --- Comment #5 from Marc Véron <veron@veron.ch> --- (In reply to Katrin Fischer from comment #4) (...)

Ideally the code should check for the existance of firstname, as we also have organisations where this field will remain empty (not displayed in the patron form even).

So I'd say something like:

surname[if firstname], firstname[end]

Katrin, I missed that while signing off because it is about instructors / teachers who normally schould have first names :-) ...but you are right, it makes sense to display the firstname only if there is a first name. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 --- Comment #7 from Marc Véron <veron@veron.ch> --- (In reply to Katrin Fischer from comment #6)

Maybe a faculty or work group account? (quote 123 :) )

Or even kind of room reservation... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- ping Nick? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 47513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47513&action=edit Bug 15699 [QA followup] - Only display firstname if present -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47423|0 |1 is obsolete| | Attachment #47513|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47545&action=edit Bug 15699 - Course reserves instructors should be in form "Surname, Firstname" for sorting purposes This patch changes the order of the name fields and adds a span class around each in case of library wanting to customize further To test: 1 - Enable course reserves 2 - Add some courses with instrcutors 3 - Note they are of form "Firstname Surname" 4 - Apply patch 5 - Note the change 6 - Note span tags 7 - Note you can hide firstname by adding to intranet user js: $(".instr_firstname, instr_separator").hide(); Sing-off note: This patch displays the names as advertised on cgi-bin/koha/opac-course-reserves.pl Sorting the names would need some more actions but seems not to be intended by this patch. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #13 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15699 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #15 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.10. -- You are receiving this mail because: You are watching all bug changes.