[Bug 15092] New: item type descriptions not showing if no logo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bug ID: 15092 Summary: item type descriptions not showing if no logo Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 10937 Created attachment 44245 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44245&action=edit missing item type images/text If there is no icon the item type description should show in the opac, but nothing is showing. Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10937 [Bug 10937] Option to hide and group itemtypes from advanced search -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com, | |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Problem here is in opac-search.pl $itemytpes = GetItemTypesCategorized; but this itemtypes don't have $itemtypes->{$thisitemtype}->{translated_description} which is the string printed I put Jonathan in CC, he knows better -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44265&action=edit Bug 15092: item type descriptions not showing in OPAC advsearch Go to OPAC > Advanced Search Tab 'Item type' only shows itemtype icons, no descriptions. Descriptions must be shown always To test: 1) Go to OPAC > Advanced search 2) Check no descriptions for item types Also check that, reloading the page, item types shows in random order 3) Apply the patch 4) Check there are descriptions now and order is by description -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|oleonard@myacpl.org |bgkriegel@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44265|0 |1 is obsolete| | --- Comment #3 from Marc Véron <veron@veron.ch> --- Created attachment 44267 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44267&action=edit Bug 15092: item type descriptions not showing in OPAC advsearch Go to OPAC > Advanced Search Tab 'Item type' only shows itemtype icons, no descriptions. Descriptions must be shown always To test: 1) Go to OPAC > Advanced search 2) Check no descriptions for item types Also check that, reloading the page, item types shows in random order 3) Apply the patch 4) Check there are descriptions now and order is by description Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44267|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44271&action=edit [PASSED QA] Bug 15092: item type descriptions not showing in OPAC advsearch Go to OPAC > Advanced Search Tab 'Item type' only shows itemtype icons, no descriptions. Descriptions must be shown always To test: 1) Go to OPAC > Advanced search 2) Check no descriptions for item types Also check that, reloading the page, item types shows in random order 3) Apply the patch 4) Check there are descriptions now and order is by description Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 44338 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44338&action=edit Bug 15092: (followup) Descriptions not show for search categories If we have some item types in search categories, description is not show in opac advanced search To test: 1) Add some item type to a search category 2) Go to OPAC > Advanced search empty description for that category 3) Apply the patch 4) Repeat 2), description must be present -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Added followup to display search categories description -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15098 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15098 [Bug 15098] Itemtype description missing from facets for itypes in a search group -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44338|0 |1 is obsolete| | --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 44366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44366&action=edit Bug 15092: (followup) Descriptions not show for search categories If we have some item types in search categories, description is not show in opac advanced search To test: 1) Add some item type to a search category 2) Go to OPAC > Advanced search empty description for that category 3) Apply the patch 4) Repeat 2), description must be present Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #9 from Marc Véron <veron@veron.ch> --- Signed-off on second patch: Bug 15092: (followup) Descriptions not show for search categories. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |critical CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44366|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44453 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44453&action=edit [PASSED QA] Bug 15092: (followup) Descriptions not show for search categories If we have some item types in search categories, description is not show in opac advanced search To test: 1) Add some item type to a search category 2) Go to OPAC > Advanced search empty description for that category 3) Apply the patch 4) Repeat 2), description must be present Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is better, but still one small glitch - if you have no OPAC description set, it should fall back to the staff description like we usually do. But maybe this should go on a separate bug, so this can go in as is as fixing the bigger problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15092 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Followup pushed to master. Thanks Bernardo! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org