[Bug 32648] New: Search.t is failing on My8?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Bug ID: 32648 Summary: Search.t is failing on My8? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 25551 koha_1 | # Failed test 'Item field returned from default XSLT if pref set' koha_1 | # at t/Search.t line 198. koha_1 | # found warning: No item at t/Search.t line 186. koha_1 | # expected to find warning: (?^u:Item here) koha_1 | # Looks like you failed 1 test of 2. koha_1 | koha_1 | # Failed test 'searchResults PassItemMarcToXSLT test' koha_1 | # at t/Search.t line 207. koha_1 | # Looks like you failed 1 test of 4. koha_1 | [11:42:56] t/Search.t Koha_Master_My8/1161 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 [Bug 25551] [OMNIBUS] Some tests are failing randomly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search.t is failing on My8? |Search.t is failing | |randomly Depends on| |28373 CC| |tomascohen@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Koha_Master/2448 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28373 [Bug 28373] Items fields not used in default XSLT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 149026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149026&action=edit Bug 32648: Avoid skipping record or hiding item It seems that depending on other tests, the item could be hidden from the record, or the entire record hidden because of the way we count hidden items. I add a mock for the two HIddenItems prefs and hardcode an xml record to avoid problematic data from test builder -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149026|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 149029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149029&action=edit Bug 32648: Avoid skipping record or hiding item It seems that depending on other tests, the item could be hidden from the record, or the entire record hidden because of the way we count hidden items. I add a mock for the two HIddenItems prefs and hardcode an xml record to avoid problematic data from test builder Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Still failing Koha_Master_MDB_Latest/1286 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #7 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Looks like it didn't work 00:19:24 koha_1 | # Failed test 'Item field returned from default XSLT if pref set' 00:19:24 koha_1 | # at t/Search.t line 239. 00:19:24 koha_1 | # found warning: No item at t/Search.t line 186. 00:19:24 koha_1 | # expected to find warning: (?^u:Item here) 00:19:24 koha_1 | # Looks like you failed 1 test of 2. 00:19:24 koha_1 | 00:19:24 koha_1 | # Failed test 'searchResults PassItemMarcToXSLT test' 00:19:24 koha_1 | # at t/Search.t line 248. 00:19:24 koha_1 | # Looks like you failed 1 test of 4. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #8)
Looks like it didn't work
00:19:24 koha_1 | # Failed test 'Item field returned from default XSLT if pref set' 00:19:24 koha_1 | # at t/Search.t line 239. 00:19:24 koha_1 | # found warning: No item at t/Search.t line 186. 00:19:24 koha_1 | # expected to find warning: (?^u:Item here) 00:19:24 koha_1 | # Looks like you failed 1 test of 2. 00:19:24 koha_1 | 00:19:24 koha_1 | # Failed test 'searchResults PassItemMarcToXSLT test' 00:19:24 koha_1 | # at t/Search.t line 248. 00:19:24 koha_1 | # Looks like you failed 1 test of 4.
Koha_Master_My8/1213 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I've reused the same order as in https://jenkins.koha-community.org/job/Koha_Master_My8/1213/consoleText And I managed to make it fails. So it's data related (and note that it's wrongly in t instead of t/db_dependent!) Will need to investigate later. To recreate run this script: https://pastebin.com/t1qmfJcS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Some debugging here, 245$a (and I think all other fields and so 952$*) had visibility=8 and so considered hidden. flush_memcached made the tests pass. We are missing a flush in another tests, but this also means that this test does not set properly the data it needs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151199&action=edit Bug 32648: Clear cache in Filter_MARC_ViewPolicy.t Search.t is failing if run after Filter_MARC_ViewPolicy.t because of a missing flush -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search.t is failing |Search.t is failing is run |randomly |after | |Filter_MARC_ViewPolicy.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Search.t is failing is run |Search.t is failing if run |after |after |Filter_MARC_ViewPolicy.t |Filter_MARC_ViewPolicy.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151199|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 151239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151239&action=edit Bug 32648: Clear cache in Filter_MARC_ViewPolicy.t Search.t is failing if run after Filter_MARC_ViewPolicy.t because of a missing flush Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |david@davidnind.com --- Comment #14 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. The main patch for this bug is already in master. 2. Before applying the additional patch: - run prove t/db_dependent/Filter_MARC_ViewPolicy.t then prove t/Search.t => t/Search.t tests will fail - run prove t/db_dependent/Filter_MARC_ViewPolicy.t then flush_memcached and then prove t/Search.t => tests pass 3. Apply the second patch and then run prove t/db_dependent/Filter_MARC_ViewPolicy.t then prove t/Search.t => tests will now pass without the flush_memcached between running the tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151239|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 151243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151243&action=edit Bug 32648: Clear cache in Filter_MARC_ViewPolicy.t Search.t is failing if run after Filter_MARC_ViewPolicy.t because of a missing flush Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Back to PQA to get the follow-up pushed.. all works as desired -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Follow-up pushed to master for 23.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00,22.11.05 |23.05.00,22.11.07,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 --- Comment #18 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32648 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Version(s)|23.05.00,22.11.07,22.11.05 |23.05.00,22.11.07 released in| | --- Comment #19 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Follow-up pushed to 22.11.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org