[Bug 28271] New: Add the ability to set a new lost status when a claim is resolved
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Bug ID: 28271 Summary: Add the ability to set a new lost status when a claim is resolved Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Circulation Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 24279 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24279 [Bug 24279] Claims Returned does not work when set from moredetail.pl or additem.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120335&action=edit Bug 28271: Add the ability to set a new lost status when a claim is resolved When a claim is resolved the librarian should be able to edit the lost status of the item. It is also letting a way out when BlockReturnOfLostItems is set (the lost status is stuck on ClaimReturnedLostValue as we remove the option to edit itemlost on the item edit form). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com | |, oleonard@myacpl.org --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch follows the discussion we had on IRC earlier today http://irc.koha-community.org/koha/2021-04-30#i_2349886 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120336&action=edit Bug 28271: Adjust API spec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- That's really nice and slick! Three bits of feedback: - if the lost value dropdown defaulted to the item's current status it would make it harder for folks to accidentally change it - it would also be helpful if the dropdown noted which lost status the item is currently at, something like "Claims Returned (current status)" - something like "Not lost" would be more clear than just a blank line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 120406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120406&action=edit Bug 28271: Preselect the current item lost value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #4)
That's really nice and slick! Three bits of feedback: - if the lost value dropdown defaulted to the item's current status it would make it harder for folks to accidentally change it
Done.
- it would also be helpful if the dropdown noted which lost status the item is currently at, something like "Claims Returned (current status)"
Can you retest and you detail a bit more? I am not sure I see where you want it displayed.
- something like "Not lost" would be more clear than just a blank line
Done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Andrew, are you happy with this patchset? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #8 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 122047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122047&action=edit Proposed wording I've attached a screenshot of the resolution interface. The item in question is currently set to the lost status cr. When resolving the claim, I'd like to see it default to maintaining the existing value. Further, it'd be helpful to have the current value noted in this dropdown. I added some wording, which I've marked with a red box. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 122054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122054&action=edit Bug 28271: Add (current status) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #8)
When resolving the claim, I'd like to see it default to maintaining the existing value.
This is how it is supposed to work already :)
Further, it'd be helpful to have the current value noted in this dropdown. I added some wording, which I've marked with a red box.
I have added "(current status)", without the uppercase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #10)
(In reply to Andrew Fuerste-Henry from comment #8)
When resolving the claim, I'd like to see it default to maintaining the existing value.
This is how it is supposed to work already :)
This is not what it was doing yesterday (see my screenshot, that book was at status "cr" but the resolution popup defaulted to "None"). But it is working correctly as I test this morning.
Further, it'd be helpful to have the current value noted in this dropdown. I added some wording, which I've marked with a red box.
I have added "(current status)", without the uppercase.
Looks great, thanks! However, this morning I went a step further and actually clicked "Resolve." In both Chrome and Firefox, when I click Resolve I get a little spinning wheel on the button that looks like Koha's working on it, but it just stops there. The browser console says ":8081/api/v1/return_claims/1/resolve:1 Failed to load resource: the server responded with a status of 400 (Bad Request)" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Depends on| |28586 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- It's a bug in master, opened bug 28586. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 [Bug 28586] Cannot resolve a claim -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28588 [Bug 28588] Add Koha::Checkouts::ReturnClaim->resolve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122054|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120406|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #120335|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122093&action=edit Bug 28271: Add the ability to set a new lost status when a claim is resolved When a claim is resolved the librarian should be able to edit the lost status of the item. It is also letting a way out when BlockReturnOfLostItems is set (the lost status is stuck on ClaimReturnedLostValue as we remove the option to edit itemlost on the item edit form). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122094&action=edit Bug 28271: Adjust API spec Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122095&action=edit Bug 28271: Preselect the current item lost value Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 122096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122096&action=edit Bug 28271: Add (current status) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122093|0 |1 is obsolete| | --- Comment #17 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 122120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122120&action=edit Bug 28271: Add the ability to set a new lost status when a claim is resolved When a claim is resolved the librarian should be able to edit the lost status of the item. It is also letting a way out when BlockReturnOfLostItems is set (the lost status is stuck on ClaimReturnedLostValue as we remove the option to edit itemlost on the item edit form). Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122094|0 |1 is obsolete| | --- Comment #18 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 122121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122121&action=edit Bug 28271: Adjust API spec Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122095|0 |1 is obsolete| | --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 122122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122122&action=edit Bug 28271: Preselect the current item lost value Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122096|0 |1 is obsolete| | --- Comment #20 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 122123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122123&action=edit Bug 28271: Add (current status) Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- *** Bug 26316 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | Status|Signed Off |Passed QA --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- 1+1 = 2, this is PQA :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|28593, 28595 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28593 [Bug 28593] Add ability to charge lost fee when applying new lost status when resolving a claim https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28595 [Bug 28595] Add ability to map preselected behavior to claims returned resolution statuses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |21.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |kyle@bywatersolutions.com Status|Pushed to master |RESOLVED --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- Enhancement not backported to 20.05 Jonathan, if you think this should be backported as a bug fix, let us know! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 --- Comment #25 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Kyle M Hall from comment #24)
Enhancement not backported to 20.05
Jonathan, if you think this should be backported as a bug fix, let us know!
Ask Andrew, but I think it would be good to have it into 21.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00 |21.11.00,21.05.11 released in| | --- Comment #26 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #27 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (20.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28271 Bug 28271 depends on bug 28586, which changed state. Bug 28586 Summary: Cannot resolve a claim https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28586 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org