[Bug 35584] New: Missing licenses in about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Bug ID: 35584 Summary: Missing licenses in about page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: victor@tuxayo.net QA Contact: testopia@bugs.koha-community.org Thanks David Nind for noticing it in Bug 34900
I've just had a quick look (not comprehensive), and it looks like there are some software licences missing, including: - DataTables (koha-tmpl/intranet-tmpl/lib/datatables) - GreyBox (koha-tmpl/intranet-tmpl/lib/greybox) - Some jQuery plugins - jsTree, rowGroup (doesn't look the same as jquery.dataTables.grouping.js), fnReloadAjax (part of DataTables?), Humanized Messages, jquery.dataTables.columnFilter.js (part of DataTables?), highlight (part of DataTables?), jquery-jeditable (koha-tmpl/intranet-tmpl/lib/jquery/plugins/) - linters (several) (koha-tmpl/intranet-tmpl/lib/linters) - sortable (koha-tmpl/intranet-tmpl/lib/linters/sortable) - vis-timeline and vis-graph2d (koha-tmpl/intranet-tmpl/lib/vis-timeline/) - media.match.js (koha-tmpl/opac-tmpl/lib/)
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Depends on| |34900 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34900 [Bug 34900] The translation of the string "The " should depend on context -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160116&action=edit Bug 35584: Add missing licenses to about page This patch adds license information to the about page which was missing for several JavaScript libraries. The patch also makes a minor change to CSS to improve alignment of content in the licenses tab. One library, vis-timeline-graph2d.min.js, lacked the correct version information in the source. This information has been added. To test, apply the patch and rebuild the staff interface CSS. - Go to the about page and open the "Licenses" tab. - Confirm that the information looks correct. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34623 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160116|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 160162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160162&action=edit Bug 35584: Add missing licenses to about page This patch adds license information to the about page which was missing for several JavaScript libraries. The patch also makes a minor change to CSS to improve alignment of content in the licenses tab. One library, vis-timeline-graph2d.min.js, lacked the correct version information in the source. This information has been added. To test, apply the patch and rebuild the staff interface CSS. - Go to the about page and open the "Licenses" tab. - Confirm that the information looks correct. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 160163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160163&action=edit Bug 35584: (follow-up) Add license information and fix sort order Add license information and links. Put in alphabetical order. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #4 from David Nind <david@davidnind.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35633 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35633 [Bug 35633] Upgrade Chocolat JS library from v1.1.0 to v1.1.2 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35638 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35638 [Bug 35638] Upgrade Enquire JS library from v2.0.1 to v2.1.6 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160162|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160231&action=edit Bug 35584: Add missing licenses to about page This patch adds license information to the about page which was missing for several JavaScript libraries. The patch also makes a minor change to CSS to improve alignment of content in the licenses tab. One library, vis-timeline-graph2d.min.js, lacked the correct version information in the source. This information has been added. To test, apply the patch and rebuild the staff interface CSS. - Go to the about page and open the "Licenses" tab. - Confirm that the information looks correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160163|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160232&action=edit Bug 35584: (follow-up) Add license information and fix sort order Add license information and links. Put in alphabetical order. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #7 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 160233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160233&action=edit Bug 35584: (QA Follow-up): Typo fix: GreBox -> Greybox Capitalization fix: JavaScript case Order to match header fix: jsTree jQuery -> jQuery jsTree Capitalization fix: treetable -> Treetable capitalization Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35640 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35640 [Bug 35640] Upgrade FileSaver JS library to v2.0.4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35642 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35642 [Bug 35642] Upgrade Font Face Observer library from v2.0.3 to v2.3.0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35643 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35643 [Bug 35643] Upgrade HC Sticky library from v2.2.3 to v2.2.7 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The dependency here is still "NSO" and the last patch here should have a proper description please :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160231|0 |1 is obsolete| | Attachment #160232|0 |1 is obsolete| | Attachment #160233|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160526&action=edit Bug 35584: Add missing licenses to about page This patch adds license information to the about page which was missing for several JavaScript libraries. The patch also makes a minor change to CSS to improve alignment of content in the licenses tab. One library, vis-timeline-graph2d.min.js, lacked the correct version information in the source. This information has been added. To test, apply the patch and rebuild the staff interface CSS. - Go to the about page and open the "Licenses" tab. - Confirm that the information looks correct. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160527&action=edit Bug 35584: (follow-up) Add license information and fix sort order Add license information and links. Put in alphabetical order. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #11 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 160528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160528&action=edit Bug 35584: (QA follow-up): Typo fix: GreBox -> Greybox Capitalization fix: JavaScript case Order to match header fix: jsTree jQuery -> jQuery jsTree Capitalization fix: treetable -> Treetable capitalization Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It looks like a double up: jQuery UI Virtual Keyboard Virtual Keyboard Same version and link? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 160653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160653&action=edit Bug 35584: (follow-up) Remove duplicate license entry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #15 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #16 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35584 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #17 from David Nind <david@davidnind.com> --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org