[Bug 6879] New: Actual price should show correctly on order line and basket summary
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Bug #: 6879 Summary: Actual price should show correctly on order line and basket summary Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: critical Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org Created attachment 5454 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5454 basket summary page I found this testing the bug for 4831. When you enter an actual price receiving items this it the price, that should be accounted as spent in the system. It should also be shown on order line. It isn't. To test: - create new fund - order item, price 8.74 - receive item, enter actual price 10.00 - search for the title in acq - check attached screenshots - basket summary page should show actual price somewhere - modifying the order line shows the wrong(!) value as actual price -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-09-18 20:39:38 UTC --- Created attachment 5455 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5455 order line - actual price should be 10.00, as was entered on receive -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=4831 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 --- Comment #2 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-09-21 18:23:04 UTC --- Created attachment 5516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5516 Use unitprice as the actual cost in neworder This fixes the problem you describe in your second point and in bug 6414 by renaming the field unitprice and using that value from the db. This way the actual cost in neworder is the same field as when you receive a shipment and what is shown on the receipt summary page (parcel.pl). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |nengard@gmail.com AssignedTo|henridamien@koha-fr.org |pelletiermaxime@gmail.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Failed QA --- Comment #3 from Nicole C. Engard <nengard@gmail.com> 2011-10-04 12:23:03 UTC --- Katrin, What's the URL for the second image you're showing? Maxime, After applying I see the value in the database properly, but I don't see the value on the basket summary page, only on the receipt page. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-04 12:26:26 UTC --- The second screenshot is the bottom of the page when you open a po line from the basket summary page for editing. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 --- Comment #5 from Nicole C. Engard <nengard@gmail.com> 2011-10-04 12:29:08 UTC --- Created attachment 5688 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5688 actual price on 'received' The actual price is showing right when I receive an order (and in the unitprice field in the database) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 --- Comment #6 from Nicole C. Engard <nengard@gmail.com> 2011-10-04 12:29:58 UTC --- Created attachment 5689 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5689 actual price wrong on order line The actual price after receiving is still wrong on the edit orderline page (cgi-bin/koha/acqui/neworderempty.pl?ordernumber=16&booksellerid=1) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=6414 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5516|0 |1 is patch| | Attachment #5516|application/octet-stream |text/plain mime type| | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5516|0 |1 is obsolete| | --- Comment #7 from Nicole C. Engard <nengard@gmail.com> 2011-10-04 13:59:39 UTC --- Created attachment 5691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5691 [SIGNED-OFF] Use unitprice in neworder so that the value is saved in the database and so it will be the same field used as to receive shipments http://bugs.koha-community.org/show_bug.cgi?id=6879 Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Signed off with a note: this doesn't fix everything mentioned in the bug. It also might clash with bug 4831 and should be tested with that patch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 --- Comment #8 from Nicole C. Engard <nengard@gmail.com> 2011-10-04 14:03:39 UTC --- Ignore my note, this was signed off after 4831 was pushed so it should be okay -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-12 10:20:39 UTC --- QA comment: Maxime, I feel your patch is in fact for 6414 and is not related to this 6879. Am I wrong ? If not, please resubmit at the proper place. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 --- Comment #10 from Maxime Pelletier <pelletiermaxime@gmail.com> 2011-10-12 14:07:42 UTC --- (In reply to comment #9)
QA comment:
Maxime, I feel your patch is in fact for 6414 and is not related to this 6879.
Am I wrong ? If not, please resubmit at the proper place.
I submitted it here because it's half the problem kf reported and I was talking about it on irc. I could submit it for 6414 and this one could be modified to only be an enhancement request to add a column actual price in the basket summary page. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5691|0 |1 is obsolete| | --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-14 10:12:30 UTC --- Comment on attachment 5691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5691 [SIGNED-OFF] Use unitprice in neworder so that the value is saved in the database and so it will be the same field used as to receive shipments moved to 6414 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent |P5 Patch Status|Signed Off |--- --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-14 10:13:02 UTC --- removed the patch status, as there are no more patches attached -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 Maxime Pelletier <pelletiermaxime@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|pelletiermaxime@gmail.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6879 mathieu saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com Assignee|koha-bugs@lists.koha-commun |mathsabypro@gmail.com |ity.org | Severity|critical |normal -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org