[Bug 20718] New: Add ability to have lists that are available to all list editors
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Bug ID: 20718 Summary: Add ability to have lists that are available to all list editors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Some librarians would like to have lists that can be shared among staff that have the lists permission. Test Plan: 1) Apply this patch 2) Create some private, public and 'staff' lists 3) Note only staff that can edit lists have access to the 'staff' lists -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 75119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75119&action=edit Bug 20718 - Add ability to have lists that are available to all list editors Some librarians would like to have lists that can be shared among staff that have the lists permission. Test Plan: 1) Apply this patch 2) Create some private, public and 'staff' lists 3) Note only staff that can edit lists have access to the 'staff' lists -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dilan@calyx.net.au --- Comment #2 from Dilan Johnpullé <dilan@calyx.net.au> --- Applied patch, created some lists including 'staff' but noticed that 'staff' lists seemingly vanish after creation. /cgi-bin/koha/virtualshelves/shelves.pl only shows private and public lists; all staff lists are invisible to the owner and anyone else. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75119|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 75201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75201&action=edit Bug 20718 - Add ability to have lists that are available to all list editors Some librarians would like to have lists that can be shared among staff that have the lists permission. Test Plan: 1) Apply this patch 2) Create some private, public and 'staff' lists 3) Note only staff that can edit lists have access to the 'staff' lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Dilan Johnpullé from comment #2)
Applied patch, created some lists including 'staff' but noticed that 'staff' lists seemingly vanish after creation.
/cgi-bin/koha/virtualshelves/shelves.pl only shows private and public lists; all staff lists are invisible to the owner and anyone else.
Should be fixed now! Please try again! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I find that my staff user can see the list created by another staff member and edit it, but can't view it. When trying to view it I get an incorrectly-styled dialog, "You do not have permission to view this list." Also, the 'delete' button appears but doesn't work. Should I be able to add to a staff list if I have the correct permission? The staff lists are not available in the "Add to list" window triggered from the biblio detail page. One QA tool failure: FAIL Koha/Virtualshelf.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD is missing for is_staff OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 76944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76944&action=edit Bug 20718: Add missing POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliwho@gmail.com --- Comment #7 from Cab Vinton <bibliwho@gmail.com> --- Tried applying the patch to several sandboxes, but without success. <h1>Something went wrong !</h1>Applying: Bug 20718 - Add ability to have lists that are available to all list editors Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 20718 - Add ability to have lists that are available to all list editors The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 20718 - Add ability to have lists that are available to all list editors 75201 - Bug 20718 - Add ability to have lists that are available to all list editors 76944 - Bug 20718: Add missing POD Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-20718---Add-ability-to-have-lists-that-are-ava-4FEpmq.patch . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Cab Vinton <bibliwho@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75201|0 |1 is obsolete| | Attachment #76944|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81135&action=edit Bug 20718 - Add ability to have lists that are available to all list editors Some librarians would like to have lists that can be shared among staff that have the lists permission. Test Plan: 1) Apply this patch 2) Create some private, public and 'staff' lists 3) Note only staff that can edit lists have access to the 'staff' lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 81136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81136&action=edit Bug 20718: Add missing POD -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |alexbuckley@catalyst.net.nz --- Comment #10 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Kyle Sorry I am finding what Owen described in comment 5 which is when other staff members try to view staff lists they see a "You do not have permission to view this list" message. This is displayed even though the staff member has 'list' permission. I'll be keen to keep testing after this is fixed, or if this is the correct behavior could you please note that. Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea@gmail.com --- Comment #11 from Liz Rea <wizzyrea@gmail.com> --- Another thing I noticed was that I couldn't seem to create a list from the search results for a "staff list," only "public" and "private" were options. It seems like that should work? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 --- Comment #12 from Liz Rea <wizzyrea@gmail.com> --- (Should add, I was doing this in the staff side, not the OPAC. I wouldn't expect staff lists to be creatable from the OPAC unless it was a staff member logged in and even that's a stretch.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dschust1@gmail.com --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 3335 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Fiona Borthwick <fiona.borthwick@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller@bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81135|0 |1 is obsolete| | Attachment #81136|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115823&action=edit Bug 20718: Add ability to have lists that are available to all list editors Some librarians would like to have lists that can be shared among staff that have the lists permission. Test Plan: 1) Apply this patch 2) Create some private, public and 'staff' lists 3) Note only staff that can edit lists have access to the 'staff' lists -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #115823|0 |1 is obsolete| | --- Comment #15 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 116716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116716&action=edit Bug 20718: Add ability to have lists that are available to all list editors Some librarians would like to have lists that can be shared among staff that have the lists permission. Test Plan: 1) Apply this patch 2) Create some private, public and 'staff' lists 3) Note only staff that can edit lists have access to the 'staff' lists Signed-off-by: Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Christian Stelzenmüller <christian.stelzenmueller@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Kyle, are staff lists private (only visible in staff) or are they public (visible in the OPAC as well)? I am wondering if the option is in the right field or should not be a checkbox. Maybe if we leave it in the pulldown, we could change it up a little so it's clear what will happen. Does the staff type affect what happens when the list is deleted? Is the list still tied to the owner or is the type enough and borrowernumber could be NULLed? Very much in favor of this feature :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #16)
Hi Kyle,
are staff lists private (only visible in staff) or are they public (visible in the OPAC as well)?
They are private, available only to staff.
I am wondering if the option is in the right field or should not be a checkbox. Maybe if we leave it in the pulldown, we could change it up a little so it's clear what will happen.
I don't see any problem with that, but it would add a lot of complication to the code and require altering the database schema which I've tried to avoid doing.
Does the staff type affect what happens when the list is deleted? Is the list still tied to the owner or is the type enough and borrowernumber could be NULLed?
If the owning staff member is deleted, the list is deleted. I see no reason that we could not null the owner! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #116716|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 118185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118185&action=edit Bug 20718: Set owner to NULL when owner is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com --- Comment #19 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Bug 26346 has an alternate approach for this, adding a new option of "staff only" for editing so a public list can be set to be editable by just the owner, just staff, or everyone. I prefer that more granular control. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26346 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |MOVED --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #19)
Bug 26346 has an alternate approach for this, adding a new option of "staff only" for editing so a public list can be set to be editable by just the owner, just staff, or everyone. I prefer that more granular control.
Sounds good! Let's close this one for now. It something goes awry with 26346 this can always be resurrected! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org