[Bug 9084] New: Dates in notices should be formatted according to dateformat system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 Priority: P5 - low Change sponsored?: --- Bug ID: 9084 Assignee: koha-bugs@lists.koha-community.org Summary: Dates in notices should be formatted according to dateformat system preference Severity: enhancement Classification: Unclassified OS: All Reporter: katrin.fischer@bsz-bw.de Hardware: All Status: NEW Version: master Component: Notices Product: Koha For some more rare cases this is already done, but a lot of dates are still in 'database format'. Example: 2012-11-14 20:50:00. This bug is for listing the problematic dates. Check in notice: <<old_issues.date_due>> <<old_issues.branchcode>> <<old_issues.returndate>> <<old_issues.issuedate>> Check out notice: <<issue_date>> Note: <<issue_date_due>> doesn't work at all -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: <<issue_date_due>> doesn't work at all < that's wrong, it was a typo in my template.:) Check in notice: <<old_issues.date_due>> <<old_issues.branchcode>> <<old_issues.returndate>> <<old_issues.issuedate>> Check out notice: <<issue_date>> <<issue_date_due>> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |mtj@kohaaloha.com --- Comment #2 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #0)
For some more rare cases this is already done, but a lot of dates are still in 'database format'. Example: 2012-11-14 20:50:00. This bug is for listing the problematic dates.
hmmm, we have just bumped into this issue too... i may be attempting a fix for this - if no one else has a fix already? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 17524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17524&action=edit Bug 9084 - Dates in notices should be formatted according to dateformat system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17524|0 |1 is obsolete| | --- Comment #4 from Mason James <mtj@kohaaloha.com> --- Created attachment 17525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17525&action=edit Bug 9084 - Dates in notices should be formatted according to dateformat system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17525|0 |1 is obsolete| | --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Created attachment 17526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17526&action=edit Bug 9084 - Dates in notices should be formatted according to dateformat system preference -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17526|0 |1 is obsolete| | --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Created attachment 17827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17827&action=edit Bug 9084 - Dates in notices should be formatted according to dateformat system preference to test… - apply patch - choose a patron to checkout item - in 'Patron messaging preferences' section, of patrons 'details' page - tick 'email' box for 'Item checkout' ---------------------------------------- Patron messaging preferences Days in advance Email Item checkout - x <==== Hold filled - - Item due - - Item check-in - - ---------------------------------------- - cut/paste below notice, for CHECKOUT, in 'Home › Tools › Notices & Slips › Modify notice' bib: <<biblio.title>> due: <<issues.date_due>> issue: <<issues.issuedate>> return: <<issues.returndate>> - delete issues and message_queue tables, before test mysql> truncate issues; mysql> truncate message_queue; - issue a test item to patron - check message_queue table for notice, with correctly formatted dates, with stripped time mysql> select content from message_queue\G content: bib: TESTAMENTS OF LOVE due: 20/05/2013 issue: 30/04/2013 return: 30/04/2013 1 row in set (0.00 sec) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17827|0 |1 is obsolete| | --- Comment #7 from Mason James <mtj@kohaaloha.com> --- Created attachment 17828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17828&action=edit Bug 9084 - Dates in notices should be formatted according to dateformat system preference to test… - apply patch - choose a patron to checkout item - in 'Patron messaging preferences' section, of patrons 'details' page - tick 'email' box for 'Item checkout' ---------------------------------------- Patron messaging preferences Days in advance Email Item checkout - x <==== Hold filled - - Item due - - Item check-in - - ---------------------------------------- - cut/paste below notice, for CHECKOUT, in 'Home › Tools › Notices & Slips › Modify notice' bib: <<biblio.title>> due: <<issues.date_due>> issue: <<issues.issuedate>> return: <<issues.returndate>> - delete issues and message_queue tables, before test mysql> truncate issues; mysql> truncate message_queue; - issue a test item to patron - check message_queue table for notice, with correctly formatted dates, with stripped time mysql> select content from message_queue\G content: bib: TESTAMENTS OF LOVE due: 20/05/2013 issue: 30/04/2013 return: 30/04/2013 1 row in set (0.00 sec) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |srdjan@catalyst.net.nz --- Comment #8 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Perhaps it would be better (quicker) if you made a hash instead of array, and use if $h{$field} instead of grep? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 Chris Rohde <crohde@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crohde@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-09-29 last check this| | --- Comment #9 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 --- Comment #10 from David Cook <dcook@prosentient.com.au> --- I'm happy to see that someone else has already started work on this one. However, I have a few reservations about this patch at the moment. 1) The list of tables.fields for which to format dates: This list isn't comprehensive (it should probably include all date columns). Also, being hard-coded, it makes for a bit of a maintenance nightmare, I think. The overdue_notices.pl and advanced-notices.pl scripts use this regex "/^date|date$/" to choose columns for which to format dates when using items.content. I think that this would make sense here too. Of course, "items.onloan" wouldn't be included in this, so we might need to use a hard-coded list, or regex + a shorter hard-coded list. 2) I don't know if we want to strip the time from all of these fields. I imagine there might be fields, like duedate, where we might want to include the time. We might not. I'm not 100% on this one. -- In any case, if the list were expanded, I would be happy to sign off. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- When did the bot|2013-09-29 00:00:00 |2013-10-30 last check this| | --- Comment #11 from I'm just a bot <gitbot@bugs.koha-community.org> --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9084 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |DUPLICATE --- Comment #12 from David Cook <dcook@prosentient.com.au> --- I hope it's appropriate that I mark this RESOLVED - DUPLICATE, but bug 11244 identifies the same problem and offers a more robust solution. *** This bug has been marked as a duplicate of bug 11244 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org