https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43756 Bug ID: 43756 Summary: EDI invoice processing receives lines for cancelled orders and re-opens them Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Koha::EDI::process_invoice receives an invoice line even when the order it refers to has been cancelled in Koha. The cancelled order is received like any other: its status is changed from cancelled to complete, quantityreceived and prices are set, and nothing is recorded in edifact_errors. Bug 38423 made process_invoice skip and report lines that cannot be receipted (no ordernumber, unknown order, deleted record) and its description names cancelled orders as one of the problem cases, but a cancelled order is not skipped. Process_invoice already records a warning for an order that is already complete; a cancelled order gets no such treatment. Reproduced on main (vendor EDI account without plugin): an order with orderstatus 'cancelled' and one linked item, and an invoice for it with QTY+47:1 and RFF+LI pointing to the order. - order status after processing: complete (quantityreceived 1) - edifact_errors: none - message status: received This silently undoes a cancellation (for example one made by staff or by an ORDRSP cancel), re-opens spent budget and gives staff no indication that the supplier invoiced a line the library believed was cancelled. Proposed behaviour: skip the line, leave the order cancelled, and add an edifact_errors row (with the invoice number) saying the invoice line refers to a cancelled order, so staff can reconcile it with the supplier. Test plan: 1. Create an order line and cancel it. 2. Process an EDIFACT invoice that refers to the order with RFF+LI. 3. Without the patch: the order becomes complete and no error is shown. 4. With the patch: the order stays cancelled, other lines on the invoice are still received, and the EDIFACT messages page shows an error for the invoice line referring to a cancelled order. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.