[Bug 31419] New: Add accesskeys to recall modal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Bug ID: 31419 Summary: Add accesskeys to recall modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com We have added accesskeys for the buttons on hold modals, we should have the same functionality on recalls -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20688, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26626 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 139473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139473&action=edit Bug 31419: Add accesskeys for modals This patch simply adds accesskey elements to the buttons, and changes an icon to be consistent with bug 26626 For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesske... To test: 1 - Generate a recall 2 - Fill it/check in 3 - Note modal now has hints "Confirm (Y)" 4 - Test with Y,P,I keys (may need to recreate recalls) 5 - Confirm the recall and test waiting recall modal too -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29734 [Bug 29734] [OMNIBUS] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139473|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 139562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139562&action=edit Bug 31419: Add accesskeys for modals This patch simply adds accesskey elements to the buttons, and changes an icon to be consistent with bug 26626 For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesske... To test: 1 - Generate a recall 2 - Fill it/check in 3 - Note modal now has hints "Confirm (Y)" 4 - Test with Y,P,I keys (may need to recreate recalls) 5 - Confirm the recall and test waiting recall modal too Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139562|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140957&action=edit Bug 31419: Add accesskeys for modals This patch simply adds accesskey elements to the buttons, and changes an icon to be consistent with bug 26626 For tips on how to access the accesskeys: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/accesske... To test: 1 - Generate a recall 2 - Fill it/check in 3 - Note modal now has hints "Confirm (Y)" 4 - Test with Y,P,I keys (may need to recreate recalls) 5 - Confirm the recall and test waiting recall modal too Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31419 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org