[Bug 26313] New: "Show analytics" link doesn't work with Elasticsearch and UseControlNumber
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Bug ID: 26313 Summary: "Show analytics" link doesn't work with Elasticsearch and UseControlNumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de The "Show analytics" links don't work with Elasticsearch and UseControlnumber enabled. To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result What the search tries to do: rcn:11388674 and (bib-level:a or bib-level:b) - find a record with $w 11388674 - that is also a serial or monographic component part (LDR pos 7) rcn: search alone works. bib-level:a alone works Something wrong with the search syntax for Elasticsearch maybe? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15851 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala@helsinki.fi, | |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109423&action=edit Bug 26313: "Show analytics" link must use uppercase for booleans In elasticsearch we only treat AND and OR as boolean operators if they are capitalized To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result - Apply patch - restart and reload - Try again - It works! - Switch SearchEngine syspref to 'Zebra' - Test again - It still works! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Well, this is interesting. Shouldn't we make the query parser handle things without case sensitivity? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #2)
Well, this is interesting. Shouldn't we make the query parser handle things without case sensitivity?
I see an advantage of this behaviour. If a record title contains 'and' or 'or' they won't get seen as boolean operators (= less accidental booleans). I believe that this is an issue with Zebra currently, but couldn't locate the right bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I agree! Let's push this forward!! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'll sign off and provide a few missing changes (OPAC). Tomas, can you then take over for QA? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109423|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109457&action=edit Bug 26313: "Show analytics" link must use uppercase for booleans In elasticsearch we only treat AND and OR as boolean operators if they are capitalized To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result - Apply patch - restart and reload - Try again - It works! - Switch SearchEngine syspref to 'Zebra' - Test again - It still works! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 109458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109458&action=edit Bug 26313: (follow-up) Fix OPAC and "Show volumes" links Elasticsearch requires the booleans in search requests to be uppercase. This fixes the "Show analytics" link in OPAC (same as first patch for intranet) and the "Show volume" link. To test both patches: Set UseControlNumber = Use 1) "Show analytics" - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - For both staff and OPAC: - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics", it should show your analytical record - Switch to "Zebra" - verify links still work. 2) "Show volumes" - Turn SearchEngine to Elasticsearch again - Pick any serial record in your database, make sure 001 is set - Set LDR, pos. 19 = a - Set - Note 001 value - Find another record and edit it - Set LDR, pos. 19 = a or b, LDR 7 not a or b (m will work) - Set 773$ title of set record $w 001 of set record - For both staff and OPAC: - Click on the "In: link, it should bring up your set record - Click on the "Show volumes" link, it should bring up the volume - Switch to "Zebra" - verify all links still work. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Show analytics" link |"Show analytics" and "Show |doesn't work with |volumes" links doyn't work |Elasticsearch and |with Elasticsearch and |UseControlNumber |UseControlNumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Show analytics" and "Show |"Show analytics" and "Show |volumes" links doyn't work |volumes" links don't work |with Elasticsearch and |with Elasticsearch and |UseControlNumber |UseControlNumber -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109457|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109458|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109509&action=edit Bug 26313: "Show analytics" link must use uppercase for booleans In elasticsearch we only treat AND and OR as boolean operators if they are capitalized To test: - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics" => there will be no result - Apply patch - restart and reload - Try again - It works! - Switch SearchEngine syspref to 'Zebra' - Test again - It still works! Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109510&action=edit Bug 26313: (follow-up) Fix OPAC and "Show volumes" links Elasticsearch requires the booleans in search requests to be uppercase. This fixes the "Show analytics" link in OPAC (same as first patch for intranet) and the "Show volume" link. To test both patches: Set UseControlNumber = Use 1) "Show analytics" - Turn SearchEngine to Elasticsearch and make sure it works - Pick any serial record in your database, make sure 001 is set - Go to new > new child record - Fill in 245 and save - For both staff and OPAC: - Click on the "In" link, it should bring you to the parent record - Click on "Show analytics", it should show your analytical record - Switch to "Zebra" - verify links still work. 2) "Show volumes" - Turn SearchEngine to Elasticsearch again - Pick any serial record in your database, make sure 001 is set - Set LDR, pos. 19 = a - Set - Note 001 value - Find another record and edit it - Set LDR, pos. 19 = a or b, LDR 7 not a or b (m will work) - Set 773$ title of set record $w 001 of set record - For both staff and OPAC: - Click on the "In: link, it should bring up your set record - Click on the "Show volumes" link, it should bring up the volume - Switch to "Zebra" - verify all links still work. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.04 released in| | CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|20.11.00, 20.05.04 |20.11.00, 20.05.04, released in| |19.11.10 Status|Pushed to stable |Pushed to oldstable CC| |aleisha@catalyst.net.nz --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26313 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |28326 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28326 [Bug 28326] If ElasticSearch enable is not possible to edit or save records with ' ES reserved charset' like [] -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org