[Bug 7108] New: opaclanguagesdisplay: Lists of "Similar" languages break display across multiple lines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Bug #: 7108 Summary: opaclanguagesdisplay: Lists of "Similar" languages break display across multiple lines Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: martin.renvoize@ptfs-europe.com QAContact: koha-bugs@lists.koha-community.org Created attachment 6081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6081 Screenshot of Problem For the quick description see screenshot attached. Detailed Description If multiple similar languages (i.e: fr-FR, fr-CS or en, en-GB) are installed and the opaclanguagesdisplay preference is set to allow patrons to choose a language then at each occurrence of a language with multiple options the display is the selector splits across multiple lines breaking the display. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|oleonard@myacpl.org |martin.renvoize@ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> 2011-10-27 17:47:13 UTC --- Created attachment 6082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6082 Proposed Patch Patch submitted that uses's floats and divs. Tested in IE and Chrome.. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-10-27 18:35:08 UTC --- I can't reproduce this problem in IE8 on Windows 7. I see the problem in Chrome (14), but this patch doesn't correct it. What OS and versions are you testing in? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> 2011-10-28 11:09:17 UTC --- Hi Owen, I'm currently testing on Linux running Chrome 15, have also testing in various versions of chrome on both Windows 7 and Ubuntu linux. All seem to have the problem, and all seemed to be fixed by the patch,.. as long as you did a hard refresh as chrome caches way too much. IE, I was using IETester on Windows 7 to test for versions 5.5 onwards. Version 5 behaves badly in all sorts of ways, but I haven't tried to cater for it in my patch. I was seeing problems in IE 6 and 7, but they appear to have cleared up without the patch. So maybe it's just a Chrome problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> 2011-10-28 11:30:07 UTC --- Silly question regarding a possibly reason you can't see the fix in chrome. Did you apply the patch and then re-install the translations? My patch only patches the file's within en, so to get it to apply to each translation installed you'll need to re-install the translations. (I just found this after spending a number of hours getting confused to why it had stopped working for me.. I had en-GB installed and it was defaulting to that instead of en and therefore ignoring my changes.) Martin -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> 2011-10-28 12:40:38 UTC --- Created attachment 6088 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6088 Signed-off patch
I had en-GB installed and it was defaulting to that instead of en and therefore ignoring my changes.
You're exactly right. I didn't expect my browser to pick en-GB on its own! I can confirm now that the problem exists in Chrome (and Safari, so it must be a WebKit thing). I still can't reproduce the problem in IE (even in IETester), but the patch doesn't seem to have any negative impact on any browser so I'm happy to sign off. Looks like we'll need a similar fix for the staff client. Have we been so negligent in testing in WebKit browsers, or did the rendering engine get revised? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> 2011-10-28 13:41:32 UTC --- Cheers Owen, I think the bugs been in webkit for quite some time without being spotted. I'll have a bash at producing something similar for the staff interface, as the bug is actually worse there, hiding some languages all-together as the div is fixed to the bottom of the browser. as a note, should I create a new bug for that and post a patch to that (possibly linking to this too) or just add the patch here? Still getting my head around koha procedure. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 --- Comment #7 from Owen Leonard <oleonard@myacpl.org> 2011-10-28 14:00:00 UTC ---
as a note, should I create a new bug for that and post a patch to that
Either way is fine. The problem is similar enough that you could put it here too and update the title of the bug. If you'd prefer to track them separately that's an option too. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> 2011-10-28 14:46:20 UTC --- Created attachment 6092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6092 Patch for Intranet Added a patch for the same thing on in the Intranet interface. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|opaclanguagesdisplay: Lists |Lists of "Similar" |of "Similar" languages |languages break display |break display across |across multiple lines in |multiple lines |both Opac and Intranet -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |I18N/L10N AssignedTo|martin.renvoize@ptfs-europe |frederic@tamil.fr |.com | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|I18N/L10N |Templates Patch Status|Signed Off |Needs Signoff AssignedTo|frederic@tamil.fr |martin.renvoize@ptfs-europe | |.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6082|0 |1 is obsolete| | Attachment #6092|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris@bigballofwax.co.nz> 2011-11-03 02:54:21 UTC --- Created attachment 6158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6158 Bug7108: Intranet Language Menu Display Patch Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl, | |oleonard@myacpl.org QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #10 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-28 09:48:07 UTC --- Owen, Did you test the languages_loo.plural case? I did not test it, but wonder if the | comes at the right place in that situation? Should it be: Lang1 | Lang2a Lang2b | Lang3 ? And wouldn't it become now: Lang1 | Lang2a | Lang2b Lang3 ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> 2011-11-30 17:38:24 UTC --- I tested with these languages enabled: en, en-GB, en-NZ, fr-FR, fr-CA, & cs-CZ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #12 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-01 07:40:02 UTC --- Thanks for responding. Tested it myself now too. Marked as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |master -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #13 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-06 11:00:03 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 --- Comment #14 from Paul Poulain <paul.poulain@biblibre.com> 2011-12-06 11:08:56 UTC --- hey ! man ! you're 160th (just added in history.txt) !!! (http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=914d4d43529b83fa...) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> 2011-12-06 11:18:53 UTC --- That's kinda cool.. :) Great to see we've got so many contributors! I'll have to start patching more often now I've worked out the procedure. Cheers -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7644 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7108 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This was incorporated into the 3.6.x branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org