[Bug 38892] New: Patron category 'can be a guarantee' means that same category cannot be a guarantor (bis)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Bug ID: 38892 Summary: Patron category 'can be a guarantee' means that same category cannot be a guarantor (bis) Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com I think this was not completely fixed in bug 37892. When adding a patron, you cannot choose a guarantor with the same category. To recreate: 1, Go to Patrons 2. Click 'New patron' > 'Kid' 3. Fill out surname and cardnumber 4. Under Patron guarantor, click Add guarantor 5. Search for category = Kid and choose one of the patrons 6. Choose the relationship 7. Click 'Save' --> Error A guarantor cannot be a guarantee. This patron is not a guarantor. This error does not make sense. ***Note that it also blocks editing a patron that has the same category as their guarantor when coming from an upgrade!*** I think this a major, if not critical. I get that the example with 'Kid' does not make much sense, but I just wanted to avoid having to go into patron categories to change the 'Patron' category for example to 'can be guarantee' and make the example with two 'Patron' patrons. Not all libraries classify their patrons with kid/adult. It might be resident/non-resident for example, and a resident parent could have a resident guarantee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12133 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=37892 CC| |hammat.wele@inlibro.com, | |philippe.blouin@inlibro.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 [Bug 12133] Guarantor requirements when registering a patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 --- Comment #1 from Blou <philippe.blouin@inlibro.com> --- Il also blocks update_patrons_category.pl from completing the change of category -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- We also noticed that this causes problems when a guarantee changes category using the script update_patrons_category.pl and is now in the same category as their guarantor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 --- Comment #3 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 176585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=176585&action=edit Bug 38892: Show correct error message when we attempt to add guarantor as a child When we attempt to add child as guarantor the error message shown is 'A guarantor cannot be a guarantee.' it doesn't make sense To recreate: 1. Go to Patrons 2. Click 'New patron' > 'Kid' 3. Fill out surname and cardnumber 4. Under Patron guarantor, click Add guarantor 5. Search for category = Kid and choose one of the patrons 6. Choose the relationship 7. Click 'Save' --> Error A guarantor cannot be a guarantee. 8. Apply the patch 9. repeat previous steps 10. After clicking Save --> the error message shown is «Child patron cannot be a guarantor.» -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |hammat.wele@inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #176585|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 177134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177134&action=edit Bug 38892: Show correct error message when we attempt to add guarantor as a child When we attempt to add child as guarantor the error message shown is 'A guarantor cannot be a guarantee.' it doesn't make sense To recreate: 1. Go to Patrons 2. Click 'New patron' > 'Kid' 3. Fill out surname and cardnumber 4. Under Patron guarantor, click Add guarantor 5. Search for category = Kid and choose one of the patrons 6. Choose the relationship 7. Click 'Save' --> Error A guarantor cannot be a guarantee. 8. Apply the patch 9. repeat previous steps 10. After clicking Save --> the error message shown is «Child patron cannot be a guarantor.» Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Summary|Patron category 'can be a |Patron category 'can be a |guarantee' means that same |guarantee' means that same |category cannot be a |category cannot be a |guarantor (bis) |guarantor (again) --- Comment #5 from David Nind <david@davidnind.com> --- I've tested, things work as per the test plan, so I've signed off. However, I'm a bit confused with this, reflecting that this area has gotten complicated! Are we saying: - At the moment (even after bug 37892), a patron can't be a guarantor for a patron in the same patron category - and that they should be able to be? - Or that they should be able to be a guarantor, as long as the patron category is not a "Category type" of "Child"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177134|0 |1 is obsolete| | --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 177628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177628&action=edit Bug 38892: Show correct error message when we attempt to add guarantor as a child When we attempt to add child as guarantor the error message shown is 'A guarantor cannot be a guarantee.' it doesn't make sense To recreate: 1. Go to Patrons 2. Click 'New patron' > 'Kid' 3. Fill out surname and cardnumber 4. Under Patron guarantor, click Add guarantor 5. Search for category = Kid and choose one of the patrons 6. Choose the relationship 7. Click 'Save' --> Error A guarantor cannot be a guarantee. 8. Apply the patch 9. repeat previous steps 10. After clicking Save --> the error message shown is «Child patron cannot be a guarantor.» Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Passing QA - the patches do what they say and the test plan works, however, the patches don't match the bug title. I cannot recreate Caroline's issue though. Two categories marked as 'Can be guarantee' and I am able to assign a relationship between two in the same category, or either way between categories. Can you write a test plan not involving child categories to help recreate Caroline? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177628|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 177840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177840&action=edit Bug 38892: Show correct error message when we attempt to add guarantor as a child When we attempt to add child as guarantor the error message shown is 'A guarantor cannot be a guarantee.' it doesn't make sense To recreate: 1. Go to Patrons 2. Click 'New patron' > 'Kid' 3. Fill out surname and cardnumber 4. Under Patron guarantor, click Add guarantor 5. Search for category = Kid and choose one of the patrons 6. Choose the relationship 7. Click 'Save' --> Error A guarantor cannot be a guarantee. 8. Apply the patch 9. repeat previous steps 10. After clicking Save --> the error message shown is «Child patron cannot be a guarantor.» Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.06 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Pushed to stable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #11 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflicts with 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38892 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #13 from David Nind <david@davidnind.com> --- Bug fix, no changes required to the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org