[Bug 7085] New: Problems with searching for orders in acquisitions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 Bug #: 7085 Summary: Problems with searching for orders in acquisitions Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/acqui/histsearch.pl OS/Version: All Status: NEW Severity: major Priority: P5 Component: Acquisitions AssignedTo: henridamien@koha-fr.org ReportedBy: katrin.fischer@bsz-bw.de QAContact: koha-bugs@lists.koha-community.org Created attachment 6048 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6048 screenshot I see some weird behaviour from the order search in acq. Currently I have 1 record ordered and have problems finding it. If I search for the title in the order search on top of acquisitions, I can find it. If I use the title option in advanced search - I don't find it. (see screenshot) I don't get any results using the date options and leaving title and all other fields blank. The logs show no errors. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|henridamien@koha-fr.org |oleonard@myacpl.org --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2011-10-25 14:11:38 UTC --- I had similar problems searching, although it was hit and miss. On a fresh database I found I couldn't search for and find the first order I added, but I could search for and find the *second* one. Checking the SQL generated by GetHistory in Acquisitions.pm I couldn't see any difference between the two queries, but I did notice that the script builds the SQL by checking if inputs are defined: if ( defined $title ) { $query .= " AND biblio.title LIKE ? "; I'm not sure when it's appropriate to use "if ( defined $input )" versus "if ( $input )," but changing it to the latter seems to make the query work. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> 2011-10-25 14:20:02 UTC --- Created attachment 6050 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6050 Proposed fix Changing "if ( defined $input )" to "if ( $input )" in the section of the script which builds the order search query seems to give successful searches where they didn't exist before. Searches from the advanced order search screen work with title, author, vendor, basket number, date, etc. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6050|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-29 13:48:29 UTC --- Created attachment 6113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6113 [SIGNED-OFF] Fix for Bug 7085 - Problems with searching for orders in acquisitions Changing "if ( defined $input )" to "if ( $input )" in the section of the script which builds the order search query seems to give successful searches where they didn't exist before. Searches from the advanced order search screen work with title, author, vendor, basket number, date, etc. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Searches for date ranges, title and author keywords give me the correct results now. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |6807 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA QAContact|koha-bugs@lists.koha-commun |ian.walls@bywatersolutions. |ity.org |com --- Comment #4 from Ian Walls <ian.walls@bywatersolutions.com> 2011-11-06 08:49:37 UTC --- Replaces 'defined' calls with Perl eval, so any params that are passed defined but 0 or '' do not invoke the addition of the SQL where clauses. Undefined values will still assess as untrue, so we don't lose anything here, just gain stricter checks. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Passed QA |Patch Pushed --- Comment #5 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-06 09:31:00 UTC --- patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_6 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger@foundations.ed | |u --- Comment #6 from Chris Nighswonger <cnighswonger@foundations.edu> 2011-11-16 14:06:07 UTC --- This patch does not apply cleanly to 3.4.x. If it should, please rebase against that branch and attach a corrected patch to this bug. cnighs@erasmus:~/koha.3.2.test (3.4.x)$ git cherry-pick -x -s 0c0ddf92113b4a5df6 Automatic cherry-pick failed. After resolving the conflicts, mark the corrected paths with 'git add <paths>' or 'git rm <paths>' and commit the result with: git commit -c 0c0ddf92113b4a5df6833f75ba5b7ad7527c5f48 cnighs@erasmus:~/koha.3.2.test (3.4.x *+)$ git status # On branch 3.4.x # Your branch is ahead of 'origin/3.4.x' by 15 commits. # # Unmerged paths: # (use "git reset HEAD <file>..." to unstage) # (use "git add/rm <file>..." as appropriate to mark resolution) # # both modified: C4/Acquisition.pm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-27 21:12:34 UTC --- Created attachment 6439 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6439 3.4.x version of patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7085 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in 3.6 prior to 3.6.5. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org