[Bug 26905] New: Purchase suggestion button hidden for users with suggestion permission but not acq permission
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Bug ID: 26905 Summary: Purchase suggestion button hidden for users with suggestion permission but not acq permission Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: gormanp@parliament.uk QA Contact: testopia@bugs.koha-community.org We have library staff who may need to submit purchase suggestions to our acquisitions team, but do not need access to the rest of the acquisitions module. We do not have purchase suggestions turned on on the OPAC. We have permissions set so that they can manage purchase suggestions, but do not have any acquisitions module permissions set. Unless I'm mistaken, the only route to access the purchase suggestion form through the staff client is through the acquisitions module, but if these users have no acquisitions permissions, they do not have the acquisitions page link available on the Koha homepage. Can I propose that a link to the purchase suggestion form be added somewhere else on the staff client homepage, so that users with this particular set of permissions can access the form without needing to have additional acquisitions permissions? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Phil <gormanp@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11911 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Henry Bolshaw <bolshawh@parliament.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bolshawh@parliament.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |oleonard@myacpl.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Owen, Katrin, do you have any ideas where we could add this link? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 114096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114096&action=edit Screenshot of proposed change I suggest we add it to the "More" menu in the header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 114097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114097&action=edit Bug 26905: Purchase suggestion button hidden for users with suggestion permission but not acq permission This patch adds a link to purchase suggestions from the header menu's "More" submenu for users with suggestions management permission. To test, apply the patch and log in to the staff interface as a user with "suggestions_manage" permission. - Click the "More" menu item in the header. You should see a link to "Suggestions" which takes you to the suggestions management page. - Log in as a user without "suggestions_manage" permission. The link should not appear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes, I thought about that as well. Maybe after "Acquisition"? Right now it's between a R and T, but others are not alpha ordered :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- And... maybe we weird "suggestion", but shouldn't we display it only if it's not accessible from the acquisition module? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)
And... maybe we weird "suggestion", but shouldn't we display it only if it's not accessible from the acquisition module?
I don't see any reason to hide it. Whether or not the user has acquisitions permissions it's still a tool that one might want to access directly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114097|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 114158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114158&action=edit Bug 26905: Purchase suggestion button hidden for users with suggestion permission but not acq permission This patch adds a link to purchase suggestions from the header menu's "More" submenu for users with suggestions management permission. To test, apply the patch and log in to the staff interface as a user with "suggestions_manage" permission. - Click the "More" menu item in the header. You should see a link to "Suggestions" which takes you to the suggestions management page. - Log in as a user without "suggestions_manage" permission. The link should not appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #114158|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114239&action=edit Bug 26905: Purchase suggestion button hidden for users with suggestion permission but not acq permission This patch adds a link to purchase suggestions from the header menu's "More" submenu for users with suggestions management permission. To test, apply the patch and log in to the staff interface as a user with "suggestions_manage" permission. - Click the "More" menu item in the header. You should see a link to "Suggestions" which takes you to the suggestions management page. - Log in as a user without "suggestions_manage" permission. The link should not appear. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice little fix, works well. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|21.05.00 |21.05.00,20.11.01 released in| | --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.01 |21.05.00,20.11.01, 20.05.07 released in| | CC| |andrew@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.07 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27260 [Bug 27260] Add homepage button for users with purchase suggestion management but no other acq permissions -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED CC| |victor@tuxayo.net --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de Documentation| |Philip Orr contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26905 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/823 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org