[Bug 15810] New: Can't create private lists if OpacAllowPublicListCreation is set to #not allow'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Bug ID: 15810 Summary: Can't create private lists if OpacAllowPublicListCreation is set to #not allow' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl If you try to create a private list from the OPAC and the OpacAllowPublicListCreation is set to 'not allow' public lists to be created by the patron, an error occurs: Koha::Schema::Result::Virtualshelve at /usr/share/koha/lib/Koha/Object.pm line -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 47981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47981&action=edit Bug 15810: Make sure the CGI->param is not called in a list context when creating private shelves This patch fixes the following bug: If OpacAllowPublicListCreation is set to "not allow", the creation of a private list raises an error at the OPAC. CGI->param is called in a list context and some parameters are not filled from the template if the pref is set to "not allow". To make sure we don't have a "Odd number of elements in anonymous hash", we force the context to scalar. Test plan: 1/ Set OpacAllowPublicListCreation to "not allow" 2/ Create private and public lists at the OPAC and the intranet => Everything should work fine with this patch applied -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15809 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47981|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 47985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47985&action=edit [SIGNED OFF] Bug 15810: Make sure the CGI->param is not called in a list context when creating private shelves This patch fixes the following bug: If OpacAllowPublicListCreation is set to "not allow", the creation of a private list raises an error at the OPAC. CGI->param is called in a list context and some parameters are not filled from the template if the pref is set to "not allow". To make sure we don't have a "Odd number of elements in anonymous hash", we force the context to scalar. Test plan: 1/ Set OpacAllowPublicListCreation to "not allow" 2/ Create private and public lists at the OPAC and the intranet => Everything should work fine with this patch applied Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15811 [Bug 15811] Redirect after adding a new list in OPAC broken -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Signed Off |Failed QA --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- I cannot re-create this bug. Is the test plan incomplete, or has this been fixed in master incidentally? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We have tested this on 3.22.3 - there it's definitely a problem. Have you set the system preference? It will hide several options from the form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't create private lists |Can't create private lists |if |if |OpacAllowPublicListCreation |OpacAllowPublicListCreation |is set to #not allow' |is set to 'not allow' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #4)
We have tested this on 3.22.3 - there it's definitely a problem. Have you set the system preference? It will hide several options from the form.
Yes, I enabled the syspref which made "private" the only list option available. Can you confirm you can recreate the bug on master? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry - can't check right now, will try later. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #6)
Sorry - can't check right now, will try later.
Confirmed the bug. I was looking in the wrong place ; ) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Yay! something off the to-do list :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47985|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 48232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48232&action=edit Bug 15810: Make sure the CGI->param is not called in a list context when creating private shelves This patch fixes the following bug: If OpacAllowPublicListCreation is set to "not allow", the creation of a private list raises an error at the OPAC. CGI->param is called in a list context and some parameters are not filled from the template if the pref is set to "not allow". To make sure we don't have a "Odd number of elements in anonymous hash", we force the context to scalar. Test plan: 1/ Set OpacAllowPublicListCreation to "not allow" 2/ Create private and public lists at the OPAC and the intranet => Everything should work fine with this patch applied Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- pushed to master - should be in the may 2016 release. thanks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15810 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.4 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org