[Bug 28812] New: Authority tag editor only copy $a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Bug ID: 28812 Summary: Authority tag editor only copy $a Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: didier.gautheron@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Depends on: 7882 Steps to reproduce: 1- Create a notice with a 700$a and 700$d 2- Click on Tag Editor 3- Only 700$a is copied Expect result: same as 19.11 all other subfields should be copied. There's now one more level in HTML tree and koha-tmpl/intranet-tmpl/prog/js/cataloging.js:openAuth() selects the wrong node. To check: still working in authorities/authorities.pl ==== diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js index f126c86de2..35cbe499ae 100644 --- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js +++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js @@ -43,8 +43,8 @@ function openAuth(tagsubfieldid,authtype,source) { var elementsubfcode=getSubfieldCode(element.name); var mainmainstring=element.value; var mainstring = new Array(); - var inputs = element.parentNode.parentNode.getElementsByTagName("input"); + var inputs = element.parentNode.parentNode.parentNode.getElementsByTagName("input"); for (var myindex =0; myindex<inputs.length;myindex++){ if (inputs[myindex].name && inputs[myindex].name.match(tagsubfield)){ var subfieldcode=getSubfieldCode(inputs[myindex].name); Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7882 [Bug 7882] Add ability to move and reorder fields and subfields in MARC editor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Authority tag editor only |Authority tag editor only |copy $a |copies $a -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Didier, are you going to submit a patch with your proposed changes? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #2 from Didier Gautheron <didier.gautheron@biblibre.com> --- Yes but I have to double check first it doesn't break in authorities/authorities.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This reads quite similar to bug 28738 - maybe a similar fix would work? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can't reproduce this issue on master? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe I am testing the wrong thing. Do you mean copying a repeatable field or are we talking about the authority linker? Authority editor or editing bibliographic records? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=28853 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- See also Bug 28853 maybe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #7 from Didier Gautheron <didier.gautheron@biblibre.com> --- (In reply to Katrin Fischer from comment #5)
Maybe I am testing the wrong thing.
Do you mean copying a repeatable field or are we talking about the authority linker? Authority editor or editing bibliographic records? Authority search Window.
1- Create a notice with a 700$a and 700$d 2- Click on 700 $a field Tag Editor 3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up 4- Apply patch 5- Redo 2 6- as in 19.11 700$a is copied in 'Search main heading ($a only)' and $d is copied in 'Search main heading' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Didier Gautheron from comment #7)
4- Apply patch
Which one? :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #9 from Didier Gautheron <didier.gautheron@biblibre.com> --- Created attachment 124116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124116&action=edit Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor To test: 1- Create a notice with a 700$a and 700$d 2- Click on 700 $a field Tag Editor 3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up 4- Apply patch 5- Redo 2 6- 700$a is copied in 'Search main heading ($a only)' and $d is copied in 'Search main heading' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |didier.gautheron@biblibre.c |ity.org |om -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #10 from Didier Gautheron <didier.gautheron@biblibre.com> --- (In reply to Jonathan Druart from comment #8)
(In reply to Didier Gautheron from comment #7)
4- Apply patch
Which one? :)
The one I forgot to add :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 George Veranis <gveranis@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124116|0 |1 is obsolete| | --- Comment #11 from George Veranis <gveranis@dataly.gr> --- Created attachment 124175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124175&action=edit Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor To test: 1- Create a notice with a 700$a and 700$d 2- Click on 700 $a field Tag Editor 3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up 4- Apply patch 5- Redo 2 6- 700$a is copied in 'Search main heading ($a only)' and $d is copied in 'Search main heading' Signed-off-by: George Veranis <gveranis@dataly.gr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124175|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 124232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124232&action=edit Bug 28812: (bug 7882 follow up) Copy all subfields in plugin editor To test: 1- Create a notice with a 700$a and 700$d 2- Click on 700 $a field Tag Editor 3- Only 700$a is copied in search windows eg /authorities/auth_finder.pl pop up 4- Apply patch 5- Redo 2 6- 700$a is copied in 'Search main heading ($a only)' and $d is copied in 'Search main heading' Signed-off-by: George Veranis <gveranis@dataly.gr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The proposed fix definitely works and fixes a bad bug. Bug 28828 is about the same issue and fount a slightly different solution that might be a little less prone to problems with future changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Authority tag editor only |Authority tag editor only |copies $a |copies $a from record to | |search form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 124241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124241&action=edit Bug 28812: Improve robustness of selector Use the same fix as bug 28828. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Pushed to master for 21.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Version(s)|21.11.00 |21.11.00,21.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.05.x for 21.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.11.00,21.05.04 |21.11.00,21.05.04,20.11.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x, will be in 20.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> --- testing this on 20.05.x to backport: - create a new record with 700$a and 700$d populated - save - edit same record - go back to 700$a - open the Tag Editor - only the value of 700$a goes in "Search main heading ($a only): " - only the value of 700$d goes in "Search main heading: " Same with an without the patch Is what is happening expected? yes: so 20.05.x isn't affected no: there is an issue even with the patch Am I actually testing the right thing? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28812 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bernard.scaife@ptfs-europe. | |com --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 28693 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org