[Bug 35354] New: Update language in System Preference EmailLibrarianWhenHoldisPlaced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Bug ID: 35354 Summary: Update language in System Preference EmailLibrarianWhenHoldisPlaced Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs@lists.koha-community.org Reporter: kelly@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org The system preference, emaillibrarianwhenholdisplaced, states, "sending an email to the Koha administrator email address whenever a hold request is placed". However, this will be sent to the library's email address if they are set up in Libraries . The fact that Koha says the email gets sent out to the Koha Admin Email would not be helpful for multi-site libraries within Koha. With more in the system preference, libraries could know more about how this will work for their set up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- # Send e-mail to librarian if syspref is active if(C4::Context->preference("emailLibrarianWhenHoldIsPlaced")){ my $patron = $hold->patron; my $library = $patron->library; if ( my $letter = C4::Letters::GetPreparedLetter ( module => 'reserves', letter_code => 'HOLDPLACED', branchcode => $branch, lang => $patron->lang, tables => { 'branches' => $library->unblessed, 'borrowers' => $patron->unblessed, 'biblio' => $biblionumber, 'biblioitems' => $biblionumber, 'items' => $checkitem, 'reserves' => $hold->unblessed, }, ) ) { my $branch_email_address = $library->inbound_email_address; C4::Letters::EnqueueLetter( { letter => $letter, borrowernumber => $borrowernumber, message_transport_type => 'email', to_address => $branch_email_address, } ); } } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 161014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161014&action=edit Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference This includes more information about the email addresses used in the system preference description. To test: * Search for EmailLibrarianWhenHoldisPlaced in administration > system preferences * Verify description * Apply patch * Verify improved description and that the links work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update language in System |Update |Preference |EmailLibrarianWhenHoldisPla |EmailLibrarianWhenHoldisPla |ced system preference |ced |description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161014|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 161103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161103&action=edit Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference This includes more information about the email addresses used in the system preference description. To test: * Search for EmailLibrarianWhenHoldisPlaced in administration > system preferences * Verify description * Apply patch * Verify improved description and that the links work as expected Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161103|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 161309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161309&action=edit Bug 35354: Update description of EmailLibrarianWhenHoldisPlaced system preference This includes more information about the email addresses used in the system preference description. To test: * Search for EmailLibrarianWhenHoldisPlaced in administration > system preferences * Verify description * Apply patch * Verify improved description and that the links work as expected Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.03 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Note that system preference real name is : emailLibrarianWhenHoldIsPlaced -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update |Update |EmailLibrarianWhenHoldisPla |emailLibrarianWhenHoldisPla |ced system preference |ced system preference |description |description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.03 |24.05.00,23.11.03,23.05.09 released in| | --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35354 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org