https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182687&action=edit Bug 39947: Do not use bg-* Bootstrap classes This patch removes a few instances of the "bg-*" class from our templates, and adds some CSS to ensure that we can safely add the ".bg-*-subtle" class to a div with ".page-section." To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Circulation and fine rules. The information about rules specificity should have a pale blue background matching the color found in an "info" style alert. - Go to Tools -> Import patrons. The "Notes" section should match what you saw in the previous step. NOTE: I made a small change to whitespace in the markup of this section to prevent the database column list from displaying without line breaks--an issue introduced by the global tidy. - Go to Authorities and perform a search which will return results. - Click Actions -> Merge on one of the results. An "info" style alert should be shown at the top of the page, "Merging with authority..." - Without completing a merge, go to the Authorities home page. You should see an identical alert. - In KTD, bibliographic record 369 can be used to test errors related to encoding problems: - Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 and confirm that you see a "warning" style alert (a pale yellow background). - Edit that record and confirm you see a similar error messages on that page. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from David Nind <david@davidnind.com> --- The patch no longer applies 8-(... git bz apply 39947 Bug 39947 - Do not use bg-* Bootstrap classes 182687 - Bug 39947: Do not use bg-* Bootstrap classes Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 39947: Do not use bg-* Bootstrap classes Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt error: Failed to merge in the changes. Patch failed at 0001 Bug 39947: Do not use bg-* Bootstrap classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182687|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182725&action=edit Bug 39947: Do not use bg-* Bootstrap classes This patch removes a few instances of the "bg-*" class from our templates, and adds some CSS to ensure that we can safely add the ".bg-*-subtle" class to a div with ".page-section." To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Circulation and fine rules. The information about rules specificity should have a pale blue background matching the color found in an "info" style alert. - Go to Tools -> Import patrons. The "Notes" section should match what you saw in the previous step. NOTE: I made a small change to whitespace in the markup of this section to prevent the database column list from displaying without line breaks--an issue introduced by the global tidy. - Go to Authorities and perform a search which will return results. - Click Actions -> Merge on one of the results. An "info" style alert should be shown at the top of the page, "Merging with authority..." - Without completing a merge, go to the Authorities home page. You should see an identical alert. - In KTD, bibliographic record 369 can be used to test errors related to encoding problems: - Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 and confirm that you see a "warning" style alert (a pale yellow background). - Edit that record and confirm you see a similar error messages on that page. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182725|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 182734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182734&action=edit Bug 39947: Do not use bg-* Bootstrap classes This patch removes a few instances of the "bg-*" class from our templates, and adds some CSS to ensure that we can safely add the ".bg-*-subtle" class to a div with ".page-section." To test, apply the patch and rebuild the staff interface CSS. - Go to Administration -> Circulation and fine rules. The information about rules specificity should have a pale blue background matching the color found in an "info" style alert. - Go to Tools -> Import patrons. The "Notes" section should match what you saw in the previous step. NOTE: I made a small change to whitespace in the markup of this section to prevent the database column list from displaying without line breaks--an issue introduced by the global tidy. - Go to Authorities and perform a search which will return results. - Click Actions -> Merge on one of the results. An "info" style alert should be shown at the top of the page, "Merging with authority..." - Without completing a merge, go to the Authorities home page. You should see an identical alert. - In KTD, bibliographic record 369 can be used to test errors related to encoding problems: - Go to http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=369 and confirm that you see a "warning" style alert (a pale yellow background). - Edit that record and confirm you see a similar error messages on that page. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Do not use bg-* Bootstrap |Use bg-*-subtle in |classes |preference to bg-* | |Bootstrap classes -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes some Bootstrap release notes| |color classes. | | | |It removes | |a few instances of the | |"bg-*" class from templates | |(used in a few places such | |as bg-info, bg-danger, | |etc.) as the styles don't | |really fit with the staff | |interface's color palette. | |Examples include the | |circulation and fine rules | |page and the patron import | |tool page. | | | |In the places | |where we don't want to use | |the corresponding alert | |classes, it adds some CSS | |so that we can safely use | |the ".bg-*-subtle" class to | |a div with | |".page-section.". | | | |(This is | |related to Bug 39274 - HTML | |bg-* elements are low | |contrast, added to Koha | |25.05, and Bug 35402 - | |Update the OPAC and staff | |interface to Bootstrap 5, | |added to Koha 24.11.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.01 released in| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39947 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.