https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39625 Gaby <gabriela.montantes@cityofcarrollton.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gabriela.montantes@cityofca | |rrollton.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39625 --- Comment #3 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Did some more digging, in every other page we set interface with get_template_and_user as "intranet". But in scv/renew etc. we call check_cookie_auth, where we don't set interface. There is a if statement where we check if interface value is present and if not, it's fetched from session params. But since C4::Context->interface always returns at least "opac" as default value if variable $interface is undef (or something else than api, opac etc.), if statement is passed and interface from session params is newer used. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39625 --- Comment #4 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- Created attachment 183856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183856&action=edit Bug 39625: Set interface correctly in check_cookie_auth When one renews or returns an item from patrons "Checkouts" table, this actions interface is recorded to statistics table as opac. We use method check_cookie_auth in scv endpoints and this method doesn't set interface value correctly. This patch fixes this by fetching interface value from session params. To test: 1. Search for a patron with renewable checkouts. 2. Renew one of patron's items by checkin it in Renew column and selecting then Renew selected items. 3. Check the statistics table which interface is recorded with following query: SELECT * FROM statistics WHERE borrowernumber=xxx AND type='renew' ORDER BY 1 DESC; => Notice that interface has value "opac" not "intranet". 4. Apply this patch. 5. Repeat steps 2. and 3. => Confirm that intreface value is now "intranet". Test returning an item the same way. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39625 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39625 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- I couldn't replicate the issue in the main - it correctly shows as 'intranet' SELECT * FROM statistics WHERE borrowernumber=49 AND type='renew' ORDER BY 1 DESC; +---------------------+--------+--------+-------+-------+---------------+------------+----------+----------+----------------+-------+--------------+-----------+ | datetime | branch | value | type | other | illrequest_id | itemnumber | itemtype | location | borrowernumber | ccode | categorycode | interface | +---------------------+--------+--------+-------+-------+---------------+------------+----------+----------+----------------+-------+--------------+-----------+ | 2025-12-08 20:17:56 | CPL | 0.0000 | renew | | NULL | 578 | BK | GEN | 49 | REF | PT | intranet | +---------------------+--------+--------+-------+-------+---------------+------------+----------+----------+----------------+-------+--------------+-----------+ 1 row in set (0.001 sec) Maybe it has been fixed by another bug? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39625 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Emmi Takkinen from comment #6)

Did you use renew functionality on Checkouts table on Patron details page or one on Circulation module (renew.pl)? Latter works correctly and interface is saved as "intranet". First one is the one that is broken.

Hi Emmi. I tested from the checkouts tab in the patron's check out section. Here is what I did using koha-testing-docker on main: 1. Checked out two items to Mary Burton (borrower number 49): - 39999000011418 (Programming perl) - 39999000005134 (Intermediate perl) 2. Went to Mary Burton's patron page > Check out - Two items checked out, renew column shows 5 of 5 renewals remaining for both items 3. In the checkouts tab, I: - selected the tick box for Intermediate perl in the renew column - clicked 'Renew selected items' 4. Access the database, koha-mysql kohadev 5. Ran the query: SELECT * FROM statistics WHERE borrowernumber=49 AND type='renew' ORDER BY 1 DESC; 6. One result from the query - interface column shows 'intranet' MariaDB [koha_kohadev]> SELECT * FROM statistics WHERE borrowernumber=49 AND type='renew' ORDER BY 1 DESC; +---------------------+--------+--------+-------+-------+---------------+------------+----------+----------+----------------+-------+--------------+-----------+ | datetime | branch | value | type | other | illrequest_id | itemnumber | itemtype | location | borrowernumber | ccode | categorycode | interface | +---------------------+--------+--------+-------+-------+---------------+------------+----------+----------+----------------+-------+--------------+-----------+ | 2025-12-13 00:37:51 | CPL | 0.0000 | renew | | NULL | 264 | BK | GEN | 49 | REF | PT | intranet | +---------------------+--------+--------+-------+-------+---------------+------------+----------+----------+----------------+-------+--------------+-----------+ 1 row in set (0.001 sec) 7. I repeated this several times, with no change. I also tested on Koha 24.05.16, and got the same results. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39625 Emmi Takkinen <emmi.takkinen@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #9 from Emmi Takkinen <emmi.takkinen@koha-suomi.fi> --- I'm still seeing this on version 26.05.04 and added some more debugging. Endpoints like holds, checkouts and renew under directory svc all return "opac" when C4::Context->interface is called. For some reason $interface is undef when they are called and thus sub interface in Context.pm always returns "opac". I've been trying to figure out if there is something in our installations that could cause this and wipes the interface variable empty but I can't really think of anything. -- You are receiving this mail because: You are watching all bug changes.